Skip to content

Conversation

@TurnrDev
Copy link

@TurnrDev TurnrDev commented Oct 18, 2025

It's using underscores on pypi
https://pypi.org/project/uk_bin_collection/#history

I can only imagine that an update to pip is not normalising them anymore

Summary by CodeRabbit

  • Bug Fixes
    • Corrected package dependency reference to resolve potential installation and compatibility issues.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 18, 2025

Walkthrough

The manifest dependency declaration was updated from uk-bin-collection>=0.159.1 to uk_bin_collection>=0.159.1, replacing hyphens with underscores in the package name. No functionality or version requirements changed.

Changes

Cohort / File(s) Change Summary
Manifest dependency update
custom_components/uk_bin_collection/manifest.json
Updated requirements field: package name changed from uk-bin-collection>=0.159.1 to uk_bin_collection>=0.159.1 (hyphen replaced with underscore)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hyphen became an underscore today,
In manifest land, where packages play,
A simple swap, a naming delight,
uk_bin_collection now shines so bright!
One tiny change, yet clean and right! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "Fix requirement name in manifest" directly and accurately summarizes the main change in the changeset. The pull request updates the manifest dependency from "uk-bin-collection" (with hyphens) to "uk_bin_collection" (with underscores) to match the actual PyPI package name, which is the core objective described in the PR. The title is concise, clear, and specific enough that a reviewer scanning commit history would immediately understand the purpose of this change without being vague or overly broad.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b39ef0 and 4ea71bb.

📒 Files selected for processing (1)
  • custom_components/uk_bin_collection/manifest.json (1 hunks)
🔇 Additional comments (1)
custom_components/uk_bin_collection/manifest.json (1)

12-12: Correct package name for pip compatibility.

The canonical PyPI package name uses underscores (uk_bin_collection), not hyphens. Updating the manifest to reflect this ensures compatibility with recent pip versions that no longer normalize hyphen-to-underscore conversions in package names. This aligns with Home Assistant's manifest format requirements.

To ensure consistency, you may want to verify that any Python imports or internal references in the codebase also use the correct package name. Please confirm:

  • Are there any other manifest files or requirement files that need this same correction?
  • Do the integration's Python files import from the correct package name?

Comment @coderabbitai help to get the list of available commands and usage tips.

@dp247 dp247 requested a review from robbrad October 18, 2025 22:55
@robbrad
Copy link
Owner

robbrad commented Oct 19, 2025

Thank you @TurnrDev can you point me to the error your seeing? or provide some logs? I dont think its PyPi. Could be home home assistant

I wrote a test script for this and both names resolve on pypi

Testing PyPI Package Name Normalization
==================================================

Testing: 'uk-bin-collection'
  [OK] Package found
  Canonical name: uk_bin_collection
  Latest version: 0.159.1
  Author: Robert Bradley
  Author email: [email protected]
  Package URL: https://pypi.org/project/uk_bin_collection/

Testing: 'uk_bin_collection'
  [OK] Package found
  Canonical name: uk_bin_collection
  Latest version: 0.159.1
  Author: Robert Bradley
  Author email: [email protected]
  Package URL: https://pypi.org/project/uk_bin_collection/

==================================================
Conclusion:
[PROVEN] Both names resolve to THE SAME PACKAGE:
  - Same canonical name: uk_bin_collection
  - Same author: Robert Bradley
  - Same package URL: https://pypi.org/project/uk_bin_collection/

This proves PyPI name normalization (PEP 503) is working.
The canonical name registered on PyPI is: 'uk_bin_collection'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants