build(deps): bump noodles-bam 0.92, noodles-sam 0.87, noodles-csi 0.58 together - #176
Merged
Conversation
…8 together Supersedes #169, #170 and #171, which each bumped one crate and all failed to compile. The errors looked like upstream API breaks — `no method metadata`, `no method unplaced_unmapped_record_count`, `mismatched types` — but they were version skew: noodles-bam depends on noodles-sam and noodles-csi, so raising one in isolation pairs a new crate against its old siblings and the mismatch surfaces in our call sites rather than theirs. Bumped as a set, nothing in this workspace needed changing: `cargo check --workspace --all-targets --all-features` is clean, 476 tests pass, and clippy adds no new warnings (the one remaining is the pre-existing proc-macro-error2 future-incompat notice from a transitive dep). Worth remembering for the next noodles bump: dependabot raises these crates individually and they will keep failing that way. They have to move together. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #169, #170 and #171.
Each of those bumped a single crate and each failed to compile. The errors read like upstream API breaks —
no method metadata,no method unplaced_unmapped_record_count,error[E0308]: mismatched types— but they are version skew, not breaks.noodles-bamdepends onnoodles-samandnoodles-csi, so raising one in isolation pairs a new crate against its old siblings, and the mismatch surfaces at our call sites rather than theirs.Bumped as a set, nothing in this workspace needed changing:
cargo check --workspace --all-targets --all-features— cleancargo test --workspace --all-features— 476 pass, 0 failcargo clippy --workspace --all-targets --all-features— no new warnings (the one remaining is the pre-existingproc-macro-error2future-incompat notice from a transitive dep)Worth carrying forward: dependabot raises these three individually and they will keep failing that way. They have to move together, so the individual PRs are best closed rather than debugged.
ort(#167) is a separate matter — that one is a genuine API break (unresolved import ort::execution_providers::CUDAExecutionProvider) and is not covered here.🤖 Generated with Claude Code