-
Notifications
You must be signed in to change notification settings - Fork 2
Cleanup + Fixup UIs #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Cleanup + Fixup UIs #131
Changes from all commits
da856c6
65a1422
1d9b438
a2564e4
24ec9eb
71bbf9f
01fb6fa
059ccde
cba26d1
371be85
1a32de2
505ec9f
42c345b
b7bdd6f
f639af5
89e0df2
5d0b3df
5c2c2ca
6775e10
bc0b729
813f4fe
3b9c110
c50137e
3c24eb0
11c167c
5c622d6
cafe6f7
f96d409
1b0f460
a402e3f
d703259
c9e3dd0
3491c52
0d45bf8
5a36bfc
6d5f63b
f0ab75e
05a1c74
2f00695
7aa5935
f6186c1
ca1331f
b44a083
62137b2
f93285c
c1a7ecc
b97d3a9
99d5d59
80bf931
22d4ea6
c26035c
6059d2c
5c1f268
1951527
2a167ce
718f8f2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,45 @@ | ||
| { | ||
| "hooks": { | ||
| "PostToolUse": [ | ||
| { | ||
| "matcher": "Write|Edit|MultiEdit|NotebookEdit", | ||
| "hooks": [ | ||
| { | ||
| "type": "command", | ||
| "command": "./tldw_chatbook/.claude/audit_system.sh post", | ||
| "description": "Analyze file modifications after operation", | ||
| "timeout": 5000, | ||
| "continueOnError": true | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "PreToolUse": [ | ||
| { | ||
| "matcher": "Write|Edit|MultiEdit|NotebookEdit", | ||
| "hooks": [ | ||
| { | ||
| "type": "command", | ||
| "command": "./tldw_chatbook/.claude/audit_system.sh pre", | ||
| "description": "Capture state before file modification", | ||
| "timeout": 200, | ||
| "continueOnError": true | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| "permissions": { | ||
| "allow": [ | ||
| "Bash(grep:*)", | ||
| "Bash(rg:*)", | ||
| "Bash(true)", | ||
| "Bash(find:*)", | ||
| "Bash(python test:*)", | ||
| "Bash(awk:*)", | ||
| "Bash(source:*)", | ||
| "Bash(pytest:*)", | ||
| "Bash(pytest:*)", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| "Bash(mkdir:*)", | ||
| "Bash(python3:*)", | ||
| "Bash(python -m pytest Tests/RAG/test_rag_properties.py::TestChunkingServiceProperties::test_chunk_by_sentences_preserves_boundaries -xvs)", | ||
| "Bash(python -m pytest Tests/RAG/test_rag_properties.py -xvs)", | ||
| "Bash(python -m pytest Tests/RAG/test_rag_properties.py::TestCacheStateMachine -xvs -k \"CacheStateMachine\")", | ||
|
|
@@ -30,8 +58,7 @@ | |
| "Bash(PYTHONPATH=. pytest Tests/Widgets/test_chat_message_enhanced.py -v --tb=short -k \"test_button_action_events or test_toggle_image_mode\")", | ||
| "Bash(PYTHONPATH=. pytest Tests/Widgets/test_chat_message_enhanced.py::TestChatMessageEnhancedInteractions::test_toggle_image_mode -v --tb=short)", | ||
| "Bash(python -m pytest Tests/ChaChaNotesDB/ -v)", | ||
| "Bash(/Users/appledev/Working/tldw_chatbook_dev/.venv/bin/python -m pytest /Users/appledev/Working/tldw_chatbook_dev/Tests/ChaChaNotesDB/ -v)", | ||
| "Bash(bash:*)", | ||
| "Bash(python -m pytest /Users/appledev/Working/tldw_chatbook_dev/Tests/ChaChaNotesDB/ -v)", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| "Bash(python -m pytest Tests/Chat/test_chat_sidebar_media_search.py::test_media_search_functionality -xvs)", | ||
| "Bash(python -m pytest Tests/Chat/test_chat_sidebar_media_search.py::test_media_review_clearing_on_new_empty_search -xvs)", | ||
| "Bash(python -m pytest Tests/Chat/test_chat_sidebar_media_search.py::test_media_search_functionality Tests/Chat/test_chat_sidebar_media_search.py::test_media_load_for_review Tests/Chat/test_chat_sidebar_media_search.py::test_media_review_clearing_on_new_empty_search -xvs)", | ||
|
|
@@ -68,35 +95,32 @@ | |
| "Bash(python -m pytest Tests/RAG/ -v)", | ||
| "Bash(python -m pytest Tests/RAG/test_full_rag.py::test_embeddings_service -v)", | ||
| "Bash(python -m pytest Tests/RAG_Search/test_embeddings_unit.py::TestEmbeddingProviders::test_provider_interface -v)", | ||
| "Bash(python:*)", | ||
| "Bash(ls:*)", | ||
| "Bash(python -m pytest Tests/RAG/simplified/ -v --tb=short)", | ||
| "Bash(python -m pytest Tests/RAG/simplified/ -v --tb=no)", | ||
| "Bash(python -m pytest Tests/RAG/simplified/test_rag_service_basic.py -v)", | ||
| "Bash(python -m pytest Tests/RAG/simplified/test_rag_service_basic.py -v --tb=short)", | ||
| "Bash(python -m pytest Tests/RAG/simplified/ -v)", | ||
| "Bash(python:*)", | ||
| "Bash(git checkout:*)", | ||
| "Bash(./build_css.sh)", | ||
| "Bash(jq:*)", | ||
| "Bash(cat:*)", | ||
| "Bash(touch:*)", | ||
| "Bash(PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 python -m pytest -c pytest_simple.ini ./Tests/Utils/ -v --tb=short)", | ||
| "Bash(timeout 30 python -m pytest:*)", | ||
| "Bash(PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 pytest Tests/Chat/test_prompt_template_manager.py Tests/Chat/test_token_counter.py Tests/Chat/test_chat_sidebar_media_search.py -v --tb=short)", | ||
| "Bash(git add:*)", | ||
| "Bash(git commit:*)", | ||
| "WebFetch(domain:textual.textualize.io)", | ||
| "Bash(rm:*)", | ||
| "Bash(/usr/bin/grep -n \"on_button_pressed\\|nav_handlers\\|button_handlers\\|Unhandled button press\" tldw_chatbook/app.py)", | ||
| "WebFetch(domain:github.com)", | ||
| "WebFetch(domain:raw.githubusercontent.com)", | ||
| "WebFetch(domain:platform.openai.com)", | ||
| "WebFetch(domain:github.com)", | ||
| "WebFetch(domain:api.github.com)", | ||
| "WebFetch(domain:raw.githubusercontent.com)", | ||
| "WebFetch(domain:modelcontextprotocol.io)" | ||
| "WebFetch(domain:modelcontextprotocol.io)", | ||
| "Bash(python -m pytest Tests/UI/test_evals_window_v2.py::test_run_button_validation -xvs --tb=line)" | ||
| ], | ||
| "deny": [] | ||
| } | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,10 @@ | ||||||||||
| https://github.com/davidfokkema/textual-plot | ||||||||||
| https://github.com/Textualize/textual-plotext | ||||||||||
|
Comment on lines
+1
to
+2
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wrap bare URLs in angle brackets or use Markdown link syntax. Lines 1-2 contain bare URLs that violate the Markdown MD034 rule ( Apply this diff to fix the formatting: -https://github.com/davidfokkema/textual-plot
-https://github.com/Textualize/textual-plotext
+<https://github.com/davidfokkema/textual-plot>
+<https://github.com/Textualize/textual-plotext>Alternatively, format as Markdown links: -https://github.com/davidfokkema/textual-plot
-https://github.com/Textualize/textual-plotext
+- [textual-plot](https://github.com/davidfokkema/textual-plot)
+- [textual-plotext](https://github.com/Textualize/textual-plotext)📝 Committable suggestion
Suggested change
🧰 Tools🪛 LanguageTool[grammar] ~2-~2: Hier könnte ein Fehler sein. (QB_NEW_DE) 🪛 markdownlint-cli2 (0.18.1)1-1: Bare URL used (MD034, no-bare-urls) 2-2: Bare URL used (MD034, no-bare-urls) 🤖 Prompt for AI Agents |
||||||||||
|
|
||||||||||
|
|
||||||||||
|
|
||||||||||
|
|
||||||||||
|
|
||||||||||
|
|
||||||||||
|
|
||||||||||
|
|
||||||||||
|
Comment on lines
+3
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove trailing empty lines. The document has unnecessary trailing empty lines after the content (lines 3–10). Clean up by removing them. 🤖 Prompt for AI Agents |
||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -284,4 +284,4 @@ height = 24 | |
| 3. Add the card name to `active_cards` in your config | ||
| 4. Set `card_selection = "my_custom_card"` to use it | ||
|
|
||
| For more details on creating custom splash screens, see the [Splash Screen Guide](../Development/SPLASH_SCREEN_GUIDE.md). | ||
| For more details on creating custom splash screens, see the [Splash Screen Guide](../Development/SplashScreens/SPLASH_SCREEN_GUIDE.md). | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The link path has been updated to include a URL-encoded space ( |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
Bash(pytest:*)permission is a duplicate of the one on the preceding line. You can remove this line to keep the permissions list clean.