Suggested update to allow for CSS only custom checkboxes#58
Open
StephenGravitt wants to merge 1 commit intormorse:masterfrom
Open
Suggested update to allow for CSS only custom checkboxes#58StephenGravitt wants to merge 1 commit intormorse:masterfrom
StephenGravitt wants to merge 1 commit intormorse:masterfrom
Conversation
…ent and for attribute matches input id. This setup enables custom css only checkboxes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Love your plugin so far. I found myself making game-time adjustments to allow for custom checkboxes which I prefer to do with CSS only. However, this is only possible if the html structure is such that the label follows the checkbox input, and the label has a "for" attribute which matches the input id attribute. If you're unfamiliar with the technique, here is an article that does a good job of covering it:
https://medium.com/claritydesignsystem/pure-css-accessible-checkboxes-and-radios-buttons-54063e759bb3
I've provided one possible solution for this idea. If you have any objections or suggestions please let me know so I can update my code.
My hope is that you'll integrate this suggestion and I can keep my plugin on the main stream vs having a custom plugin to maintain.