fix(4756): object reference sharing in arrays with discriminated unions and minItems #4757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…minItems Fixes rjsf-team#4756 When arrays with minItems > 0 were populated for discriminated unions (oneOf with discriminator), the Array.fill() method created shared object references instead of independent instances. This caused form field changes to affect multiple array items simultaneously. Solution: - Replace Array.fill() with Array.from() in getArrayDefaults function - Array.from() creates independent object instances for each array item - Maintains existing behavior while fixing the reference sharing bug Added comprehensive test coverage for: - Basic object independence in arrays - Nested object scenarios - Exact reproduction case from issue rjsf-team#4756 - Integration with discriminated union schemas
heath-freenome
approved these changes
Sep 3, 2025
x0k
added a commit
to x0k/svelte-jsonschema-form
that referenced
this pull request
Sep 3, 2025
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Sep 3, 2025
Fixes rjsf-team#4757 by switching the `cjs` build process to produce `.cjs` files instead of `.js` files in the distribution - Updated all `package.json` files to change the `build:cjs` script to produce `.cjs` files - Updated the `v6.x upgrade guide.md` and `CHANGELOG.md` to document the change
8 tasks
heath-freenome
added a commit
that referenced
this pull request
Sep 3, 2025
* Fix 4757 by generating .cjs files for the cjs distro Fixes #4757 by switching the `cjs` build process to produce `.cjs` files instead of `.js` files in the distribution - Updated all `package.json` files to change the `build:cjs` script to produce `.cjs` files - Updated the `v6.x upgrade guide.md` and `CHANGELOG.md` to document the change * - Fixed the `require` statements in the `exports` to use `.cjs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
This change fixes #4756 where array items shared object references when using discriminated unions (
oneOf) combined withminItems > 0and undefined initial form data.Problem
When arrays needed to be populated to meet
minItemsrequirements, theArray.fill()method created shared object references instead of independent instances. This caused form field changes in one array item to unintentionally affect other array items.Impact
minItems > 0+ undefined initial form dataTesting
getDefaultFormStateTest.tsChecklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.