Skip to content

Conversation

@Rot127
Copy link
Member

@Rot127 Rot127 commented Jul 6, 2025

…uded.

Your checklist for this pull request

Detailed description

Test plan (required)

Closing issues

Copy link

@notxvilka notxvilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though we probably need also a PR for the site as well.

@karliss
Copy link
Member

karliss commented Jul 6, 2025

Related #3507

@karliss
Copy link
Member

karliss commented Jul 6, 2025

I am starting to get some doubts about renaming. Changing the windows .zip name is fine, but on linux it's the name of the ~executable app. Not sure about macOS whether it will change only .dmg which would be fine or the .app as well.

If only .dmg but not .app can be renamed, I guess I am fine with ugly appimage name.

@karliss
Copy link
Member

karliss commented Jul 6, 2025

image

README.md Outdated
Cutter release binaries for all major platforms (Linux, macOS, Windows) can be downloaded from [GitHub Releases](https://github.com/rizinorg/cutter/releases).

> [!NOTE]
> The packages already includes all maintained plugins like rz-ghidra and others.
Copy link
Member

@karliss karliss Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer explicit list, maybe in the plugin section. It's not obvious which ones are considered "All maintained plugins", And the plugins repo https://github.com/rizinorg/cutter-plugins contains quite a few community plugins labelled "maintained" so phrase "all maintained" can be quite misleading.

@Rot127
Copy link
Member Author

Rot127 commented Jul 7, 2025

Made your changes.
Test release so we can check it: https://github.com/Rot127/cutter/releases/tag/test-release-pkg-plugins

@Rot127
Copy link
Member Author

Rot127 commented Jul 21, 2025

@karliss

If only .dmg but not .app can be renamed, I guess I am fine with ugly appimage name.

This would be inconsistent though. People might come to the release page and wonder if only the MacOS version contains all plugins.
If you don't want to change the executable file names (totally fine), we can also go with a note on the release page, the docs and webpage alone.
Basically like the note in the README.

@karliss
Copy link
Member

karliss commented Jul 21, 2025

People might come to the release page and wonder if only the MacOS version contains all plugins.

Where did that come from? By .app I am referring to the macos app within the dmg not the appimage. And I already told that I am fine with ugly appimage name as long as for macos and windows it only changes external package name not the executable within. It was kind of long and ugly already before the changes.

@Rot127
Copy link
Member Author

Rot127 commented Jul 21, 2025

Ah sorry. I misread you. I'll change the names again and see if the executables actually change as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants