-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add +plugins suffix to package name to prevent confusion what is incl… #3506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
notxvilka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Though we probably need also a PR for the site as well.
|
Related #3507 |
|
I am starting to get some doubts about renaming. Changing the windows .zip name is fine, but on linux it's the name of the ~executable app. Not sure about macOS whether it will change only .dmg which would be fine or the .app as well. If only .dmg but not .app can be renamed, I guess I am fine with ugly appimage name. |
README.md
Outdated
| Cutter release binaries for all major platforms (Linux, macOS, Windows) can be downloaded from [GitHub Releases](https://github.com/rizinorg/cutter/releases). | ||
|
|
||
| > [!NOTE] | ||
| > The packages already includes all maintained plugins like rz-ghidra and others. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer explicit list, maybe in the plugin section. It's not obvious which ones are considered "All maintained plugins", And the plugins repo https://github.com/rizinorg/cutter-plugins contains quite a few community plugins labelled "maintained" so phrase "all maintained" can be quite misleading.
|
Made your changes. |
This would be inconsistent though. People might come to the release page and wonder if only the MacOS version contains all plugins. |
Where did that come from? By .app I am referring to the macos app within the dmg not the appimage. And I already told that I am fine with ugly appimage name as long as for macos and windows it only changes external package name not the executable within. It was kind of long and ugly already before the changes. |
|
Ah sorry. I misread you. I'll change the names again and see if the executables actually change as well. |

…uded.
Your checklist for this pull request
Detailed description
Test plan (required)
Closing issues