Add a scroll bar to the hex widget #3499
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notxvilka
requested changes
May 26, 2025
notxvilka
requested changes
May 26, 2025
karliss
requested changes
May 27, 2025
karliss
requested changes
Jun 3, 2025
Member
karliss
left a comment
karliss
left a comment
There was a problem hiding this comment.
Scrollbar should be tied to displayed position not the cursor position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Implements a scroll bar for the hex dump viewer, and also moves most of the disassembly widget's scroll bar code into an AddressRangeScrollBar class for reusability.
Test plan (required)
Performed every test in #3430, but with the hex viewer instead of the disassembly window.
Closing issues
Closes #839.