-
Notifications
You must be signed in to change notification settings - Fork 117
feat: add datacenter field to actors list row #3018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jog1t
wants to merge
1
commit into
09-29-feat_add_datacenter_field_to_runners_table
from
09-29-feat_add_datacenter_field_to_actors_list_row
Closed
feat: add datacenter field to actors list row #3018
jog1t
wants to merge
1
commit into
09-29-feat_add_datacenter_field_to_runners_table
from
09-29-feat_add_datacenter_field_to_actors_list_row
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 29, 2025
Closed
Closed
Claude encountered an error —— View job I'll analyze this and get back to you. |
This was referenced Sep 29, 2025
Closed
This was referenced Sep 29, 2025
commit: |
Graphite Automations"Test" took an action on this PR • (09/29/25)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
NathanFlurry
approved these changes
Oct 1, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
Closes FRONT-793 ### TL;DR Added the ability to display datacenter information for actors in the actors list. ### What changed? - Added `actorDatacenterQueryOptions` to the default data provider to fetch datacenter information for actors - Added a new `showDatacenter` filter option in the actor filters context - Created a new `Datacenter` component in the actors list row to display the datacenter information - Extended the `Actor` type to include an optional `datacenter` field - Made the "showDestroyed" filter available for both "engine" and "cloud" app types ### How to test? 1. Open the actors list view 2. Enable the "Show Actors Datacenter" filter option 3. Verify that datacenter information appears under the actor ID for actors that have datacenter data 4. Verify that actors without datacenter data show a "-" indicator 5. Disable the filter and confirm the datacenter information is hidden ### Why make this change? This change improves observability by allowing users to see which datacenter each actor is running in. This information is particularly valuable in multi-datacenter deployments where understanding the physical location of actors can help with troubleshooting, performance analysis, and capacity planning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FRONT-793
TL;DR
Added the ability to display datacenter information for actors in the actors list.
What changed?
actorDatacenterQueryOptions
to the default data provider to fetch datacenter information for actorsshowDatacenter
filter option in the actor filters contextDatacenter
component in the actors list row to display the datacenter informationActor
type to include an optionaldatacenter
fieldHow to test?
Why make this change?
This change improves observability by allowing users to see which datacenter each actor is running in. This information is particularly valuable in multi-datacenter deployments where understanding the physical location of actors can help with troubleshooting, performance analysis, and capacity planning.