feat(toolchain): build args support for remote builds - #2583
Closed
abcxff wants to merge 1 commit into
Closed
Conversation
Contributor
Author
Deploying rivet with
|
| Latest commit: |
b90675b
|
| Status: | 🚫 Build failed. |
NathanFlurry
requested changes
Jun 11, 2025
NathanFlurry
left a comment
NathanFlurry
left a comment
Member
There was a problem hiding this comment.
- serialize args on rust side
- implement target
abcxff
marked this pull request as ready for review
June 11, 2025 23:38
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Adds Docker build argument support for remote builds in Rivet's CI system, enabling dynamic configuration during build time through multiple components.
- Added new
cloud/packages/ci-manager/src/common.tswith utility functions for handling build argument escaping and conversion - Introduced
cloud/packages/ci-runner/entry.shto safely process build arguments using UNIT_SEP_CHAR (0x1F) delimiter - Modified
cloud/packages/ci-manager/src/types.tsto add requiredbuildArgs: Record<string, string>to BuildInfo interface - Enhanced
/buildsendpoint incloud/packages/ci-manager/src/server.tswith validation for build argument format and sanitization - Updated Kaniko execution in Docker and Rivet executors to properly handle space-containing build arguments
9 files reviewed, 7 comments
Edit PR Review Bot Settings | Greptile
abcxff
force-pushed
the
06-11-feat_toolchain_build_args_support_for_remote_builds
branch
from
June 12, 2025 00:13
55281e5 to
c2676b7
Compare
NathanFlurry
requested changes
Jun 12, 2025
abcxff
force-pushed
the
06-11-feat_toolchain_build_args_support_for_remote_builds
branch
2 times, most recently
from
June 12, 2025 02:06
8675015 to
fbbfba0
Compare
NathanFlurry
approved these changes
Jun 12, 2025
abcxff
changed the base branch from
06-09-feat_toolchain_remote_build_method
to
graphite-base/2583
June 12, 2025 22:52
Deploying rivet-studio with
|
| Latest commit: |
b90675b
|
| Status: | 🚫 Build failed. |
abcxff
changed the base branch from
graphite-base/2583
to
06-09-feat_toolchain_remote_build_method
June 13, 2025 17:13
Deploying rivet-hub with
|
| Latest commit: |
b90675b
|
| Status: | 🚫 Build failed. |
NathanFlurry
changed the base branch from
06-09-feat_toolchain_remote_build_method
to
graphite-base/2583
June 13, 2025 22:41
This was referenced Jun 13, 2025
This was referenced Jun 17, 2025
abcxff
changed the base branch from
graphite-base/2583
to
06-09-feat_toolchain_remote_build_method
June 18, 2025 16:38
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| `--destination=${args.destination}`, | ||
| `--upload-tar=${args.outputUrl}`, | ||
| `--dockerfile=${args.dockerfilePath}`, | ||
| ...(args.buildTarget ? [`--target='${args.buildTarget}'`] : []), |
Contributor
There was a problem hiding this comment.
The --target argument should not include single quotes around the value. This will cause the quotes to be passed literally to the Docker build process, which will fail to find the target.
Change:
...(args.buildTarget ? [`--target='${args.buildTarget}'`] : []),To:
...(args.buildTarget ? [`--target=${args.buildTarget}`] : []),
Suggested change
| ...(args.buildTarget ? [`--target='${args.buildTarget}'`] : []), | |
| ...(args.buildTarget ? [`--target=${args.buildTarget}`] : []), |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
MasterPtato
changed the base branch from
06-09-feat_toolchain_remote_build_method
to
graphite-base/2583
June 18, 2025 23:46
This was referenced Jun 19, 2025
This was referenced Jun 20, 2025
Contributor
Merge activity
|
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 20, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes RVT-4787 <!-- If there are frontend changes, please include screenshots. -->
graphite-app
Bot
deleted the
06-11-feat_toolchain_build_args_support_for_remote_builds
branch
June 20, 2025 19:24
This was referenced Jun 20, 2025
Closed
This was referenced Jun 28, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
RVT-4787