Skip to content

Conversation

dqhl76
Copy link
Contributor

@dqhl76 dqhl76 commented Sep 5, 2025

The windows-2019 runner image is being deprecated, consider switching to windows-2022(windows-latest) or windows-2025 instead.

I tested in the fork repo: https://github.com/dqhl76/sqllogictest-rs/actions/runs/17488369539/job/49672293482

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xxchan xxchan merged commit 265f332 into risinglightdb:main Sep 7, 2025
4 checks passed
@dqhl76 dqhl76 deleted the fix-release branch September 7, 2025 07:31
@dqhl76
Copy link
Contributor Author

dqhl76 commented Sep 7, 2025

@xxchan Thanks for the review. Although the workflow is fixed, v0.28.4 hasn’t been published on crates.io yet. Would you mind publishing it manually?

@xxchan
Copy link
Member

xxchan commented Sep 8, 2025

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants