Conversation
cchardet 2.1.7 ships no pyproject.toml and its sdist bundles a pre-cythonised _cchardet.cpp that references longintrepr.h, removed from Python 3.12's public headers, so the sdist must be rebuilt with Cython preinstalled and --no-build-isolation to embed a fresh, compatible .cpp. Upstream's own now-active master branch (2.2.0-alpha) confirms this same recipe (cython --cplus + --no-build-isolation). Testing replaces upstream's nose-based src/tests/test.py (dead on modern Python) with an equivalent pytest suite run against the bundled testdata/samples.
package-dir is pkg/, but cibuildwheel resolves CIBW_TEST_SOURCES/CIBW_TEST_COMMAND paths relative to the invocation cwd, so the staged test file and data need the pkg/ prefix throughout (confirmed against CI: both failing jobs errored with "Test source riscv64_test_cchardet.py does not exist").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cchardet2.1.7Wraps
uchardet(bundled C++ source) as a Cython extension for fast charset detection. Upstream publishes no riscv64 wheel, and its PyPI release stops at cp39.Loosely mirrors upstream's old
build-linux.yml.Differs from upstream
--no-build-isolation- the tag ships nopyproject.toml, and its bundled.cppis whatever a baresetuptools/wheelenv leaves behind (stale, and incompatible with Python 3.12+'s headers).Testing
src/tests/test.py's checks in pytest - the original usesnose, which does not run on modern Python.License: OK - wheel ships the same MPL 1.1
COPYINGas the bundleduchardetsources.Built on cp312; 7 passed, 0 skipped.