Conversation
Builds the pylsqpack._binding extension (a plain C wrapper around the vendored ls-qpack QPACK library) for riscv64; upstream publishes no riscv64 wheel. Includes a patch to ship the vendored ls-qpack/xxhash licences alongside pylsqpack's own.
luhenry
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pylsqpack0.3.24Compiles
pylsqpack._binding, a plain C wrapper around the vendoredls-qpackQPACK header-compression library, into acp310-abi3extension. Upstream publishes no riscv64 wheel.Mirrors upstream's
tests.ymlpackage-wheeljob.Differs from upstream
cp310throughcp314explicitly (not upstream's default set) -binding.cdefinesPY_SSIZE_T_CLEAN, so the abi3 wheel must be compiled on the oldest interpreter its tag claims.Testing
python -m unittest discover), plus asserting the vendored licences land indist-info/licenses/.License: Wheel bundles ls-qpack (MIT) and xxHash (BSD-2-Clause) compiled straight into the extension; upstream ships no licence text for either, so the build adds it.
Patches
0001-add-the-vendored-ls-qpack-xxhash-licences-next-to-th.patch- Not yet submitted upstream. Without it the wheel ships only pylsqpack's own LICENSE. Reproduces on any platform.Built on cp312; 14 passed.