nodejs-wheel-binaries: add build-nodejs-wheel-binaries.yml for riscv64 wheels - #860
Open
luhenry wants to merge 2 commits into
Open
nodejs-wheel-binaries: add build-nodejs-wheel-binaries.yml for riscv64 wheels#860luhenry wants to merge 2 commits into
luhenry wants to merge 2 commits into
Conversation
nodejs-wheel-binaries builds Node.js itself from source via CMake ExternalProject_Add (upstream's own configure/make, same on every platform) rather than vendoring a prebuilt binary, and Node 24.19.0's configure.py/V8 both support riscv64 natively.
The riscv64 build job failed 30 minutes in: gcc rejected the x86-only -m64 flag while compiling OpenSSL. Node's deps/openssl/openssl_asm.gypi has no riscv64 branch, so its catch-all fallback wrongly includes the linux-x86_64 asm config. --openssl-no-asm selects the no-asm config, which does have a riscv64 branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodejs-wheel-binaries24.19.0Compiles Node.js itself from source via CMake
ExternalProject_Add(upstream's ownconfigure && make, unchanged from its x86_64/aarch64 jobs). Upstream publishes no riscv64 wheel.Mirrors upstream's
build_wheel.ymlLinux job.Differs from upstream
Matrix: one
cp312-manylinux_riscv64job - the wheel tag ispy2.py3(interpreter-independent), matching upstream's ownbuild = ["cp311-*"]restriction.Testing
License: OK
Patches
0001-riscv64-pass-openssl-no-asm-to-Node-s-configure.patch- To upstream. Node's vendored OpenSSL has no riscv64 asm config, so its build falls back to a config carrying the x86-only-m64flag, which gcc rejects. Reproduces on riscv64 only.CI running - will update this line with the riscv64 job's pass/skip counts once it completes.