Conversation
Major version bumps: - revm 36 → 38, op-revm 17 → 19 - revm-statetest-types 16 → 17.0.1, revme 13 → 15 - alloy-consensus/provider/rpc-types-eth/transport 1.7.3 → 2.0.1 (pin removed) - op-alloy-consensus/network/rpc-types 0.24 → 2.0.0 Minor/patch bumps: bitflags, clap, hashbrown, rand, rayon, tokio, plus ~40 transitive lock-file updates. Source fixes for breaking changes: - chain.rs: add block_timestamp field to Transaction initialiser (alloy 2.0) - rise.rs: handle new OpTxType::PostExec variant (op-alloy 2.0) - vm.rs: gas_used() → tx_gas_used() (deprecated after EIP-8037 gas split) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
hai-rise
requested review from
datnguyencse,
duyquang6,
kien-rise and
phuocthanhdo
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily focuses on upgrading core dependencies, including moving to Alloy v2, REVM v38, and OP-Alloy v2. It also introduces support for the PostExec transaction type within the Rise chain implementation and adds a block_timestamp field to transaction recovery. Additionally, gas usage tracking is updated to use tx_gas_used() instead of gas_used(). I have no feedback to provide.
revm now validates nonce < u64::MAX at the transaction validation stage, returning NonceOverflowInTransaction instead of letting PEVM detect inconsistency as NonceMismatch after execution. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major version bumps:
Minor/patch bumps: bitflags, clap, hashbrown, rand, rayon, tokio, plus ~40 transitive lock-file updates.
Source fixes for breaking changes: