Skip to content

fix: emoji annoys string.count #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: emoji annoys string.count #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fef9d20
fix: emoji annoys string.count
sakmt Sep 18, 2018
af9c19d
Fix: make delegate weak
sakmt Nov 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RegeributedTextView/Classes/RegeributedTextView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ open class RegeributedTextView: UITextView {

fileprivate var tapAttributedTextGesture: UITapGestureRecognizer?

private var _delegate: RegeributedTextViewDelegate?
private weak var _delegate: RegeributedTextViewDelegate?

private var attributedRanges: [AttributedRange] = [] {
didSet {
Expand Down
2 changes: 1 addition & 1 deletion RegeributedTextView/Classes/StringExt.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ extension String {
// Returns matched range list by regular expression.
func matched(by regex: String) -> [Range<String.Index>] {
let result = try? NSRegularExpression(pattern: regex, options: [])
.matches(in: self, options: [], range: NSRange(location: 0, length: self.count))
.matches(in: self, options: [], range: NSRange(location: 0, length: self.utf16.count))
.flatMap{ $0.range(at: 0).range(for: self) }
return result ?? []
}
Expand Down