Feat: Add a distinct error state to ExportButton instead of mislabeling failures as complete - #1086
Open
Olamidepy wants to merge 6 commits into
Open
Feat: Add a distinct error state to ExportButton instead of mislabeling failures as complete#1086Olamidepy wants to merge 6 commits into
Olamidepy wants to merge 6 commits into
Conversation
|
@Olamidepy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #990
Previously, ExportButton surfaced export failures by reusing the completed progress stage at 100%, mislabeling failed exports as complete. Additionally, there was no distinct red error styling or guard against missing/empty templateId.
Key Changes
Explicit Error State: Added 'failed' to ExportProgressState.stage so failures are no longer mislabeled as completed.
Distinct Red Styling: Applied text-red-600 and bg-red-600 for failed progress bars and error messages.
Empty Template Guard: Automatically disabled the button when templateId is empty or whitespace.
Unit Tests: Added tests covering empty templateId guards, failed export error rendering, and successful export flows.