Skip to content

Conversation

@tonyespy
Copy link
Contributor

Added multi-modem support to set-call-forwarding, changed test-call-forwarding to verify the expected CF properties and implement a KeyboardInterrupt handler so a backtrace isn't output when Ctrl-C is used to terminate the main loop.

Also added cf.SetProperty calls for "VoiceBusy" and "VoiceNotReachable" to fully cover all of the properties.

Added multi-modem support to set-call-forwarding,
changed test-call-forwarding to verify the expected
CF properties and implement a KeyboardInterrupt
handler so a backtrace isn't output when Ctrl-C
is used to terminate the main loop.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you do this change? The set you use between the brackets is exactly the same contained in "properties".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this so that I could get rid of the first test case in:

https://wiki.ubuntu.com/Process/Merges/TestPlans/ofono/CallForwarding

This change now causes the script to verify that the interface and all the properties are properly exported.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, but taking into account that that is Ubuntu Touch's test plan, I am not sure if upstream would accept this change if that is the only reason. If we want to fully automatize CallForwarding testing I think we should create a different script similar to the ones you created for testing the SIM interface, because I do not think that test-call-forwarding fully fits our testing needs.

@alfonsosanchezbeato
Copy link
Contributor

Looks good, although I have a couple of comments.

Also, it would be good to handle Ctrl+C in set-call-forwarding in the same way you do for test-call-forwarding, and add a time out to exit for both scripts.

Finally, I think it's worth upstreaming this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants