Skip to content

feat: add combo bar chart #7834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

feat: add combo bar chart #7834

wants to merge 9 commits into from

Conversation

djbarnwal
Copy link
Member

Adds combo bar chart

https://www.notion.so/rilldata/Multiple-Metrics-Dual-Axis-Support-in-Canvas-Charts-255ba33c8f5780ffa3fbccf4309104a4?source=copy_link#255ba33c8f57801bb6d1dba2d2540493

Closes https://linear.app/rilldata/issue/APP-291/support-for-combo-chart-type-with-dual-y-axes

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@ericokuma Linear
Copy link
Contributor

https://www.loom.com/share/551bf8c99fc947f1a6ae464e6f534888?sid=58ae880d-5a43-4733-9268-37f04dc93c5f

ericokuma
ericokuma requested changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@ericokuma ericokuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's my local project but i'm not able to get the combo chart to work

@djbarnwal djbarnwal requested a review from ericokuma August 27, 2025 13:44
ericokuma
ericokuma approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@ericokuma ericokuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djbarnwal djbarnwal mentioned this pull request Sep 2, 2025
Merged
8 tasks
@djbarnwal
Copy link
Member Author

Merged along with #7834

@djbarnwal djbarnwal closed this Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangregoryholmes briangregoryholmes briangregoryholmes approved these changes

@ericokuma ericokuma ericokuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djbarnwal @ericokuma @briangregoryholmes