fix(frontend): make disabled rerun fields legible in dark mode - #2498
Open
feiiiiii5 wants to merge 2 commits into
Open
fix(frontend): make disabled rerun fields legible in dark mode#2498feiiiiii5 wants to merge 2 commits into
feiiiiii5 wants to merge 2 commits into
Conversation
Signed-off-by: fei <204683769+feiiiiii5@users.noreply.github.com>
2 tasks
|
Looks good. Switching disabled drawer field text to |
The hardcoded-styles CI scanner treats "rhesis-ai#2400" in a comment as a color. Rephrase the comment to reference the issue number without a hex-like token. Signed-off-by: fei <204683769+feiiiiii5@users.noreply.github.com>
![peqy[bot]](https://avatars.githubusercontent.com/in/1930020?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2400
What
Disabled fields in the re-run test modal were invisible in dark mode: drawerDisabledFieldSx coloured the text with greyscale.border, which has almost no contrast against the dark drawer surface.
Change
Use text.secondary for the disabled field text (both color and WebkitTextFillColor), so disabled options stay visible but clearly marked as disabled in both themes.
Verification
npm run type-check passes; eslint and prettier clean on the changed file. Change is styling-only in the shared drawer form field style.