authvar: Remove unreachable free() - #128
Merged
Merged
Conversation
Author
|
I first hit this with pesign-113 which ONIE packages. I can't reproduce the original error with pesign/main on fedora:rawhide as I suspect the optimization behaviour may have changed (there are certainly some cflags changes between 113 and main). Nevertheless the code is still unreachable so removing it is probably still a good idea. |
Member
|
Thanks for this. Unfortunately gcc has led you to misidentify the problem, which is that the poptOptions stanza for specifying the token is missing. So I've fixed that here, and given you credit in the commit message for pointing it out. |
Chris Packham noticed that with GCC 15, when building authvar with
`-flto`, it produced the following compiler warning/error:
authvar.c: In function 'main':
authvar.c:450:17: error: 'free' called on a pointer to an unallocated object '"NSS Certificate DB"' [-Werror=free-nonheap-object]
450 | free(tokenname);
| ^
authvar.c:270:15: note: assigned here
270 | char *tokenname = "NSS Certificate DB";
| ^
lto1: all warnings being treated as errors
lto-wrapper: fatal error: gcc returned 1 exit status
This is happening because the entry in the poptOptions array for setting
the token is missing, and therefore we never use the code to set
anything other than the original, so this allocation never happens.
This adds that stanza. Thanks to Chris for noticing.
Signed-off-by: Peter Jones <pjones@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building using GCC 15 the following error is hit
This might be a false positive since the tokenname != origtoken condition should never be satisfied but it might also be an indication that lto or other optimisations have elided some code that they shouldn't have. Regardless tokenname is allocated on the stack and never modified so the call to free() and the origtoken local aren't needed and can be dropped.