Improve Appstream metadata for Flathub and introduce CMake option for Flathub offline builds - #1056
Open
AlexanderRitter02 wants to merge 2 commits into
Open
Improve Appstream metadata for Flathub and introduce CMake option for Flathub offline builds#1056AlexanderRitter02 wants to merge 2 commits into
AlexanderRitter02 wants to merge 2 commits into
Conversation
a) Appstream validation using 'appstreamcli validate --pedantic dev.brickstore.BrickStore.metainfo.xml': - developer-info-missing: Added the developer tag - description-para-markup-invalid ul: Added closing </p> paragraphs elements before unordered list <ul> in the description b) Flathub guidelines https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines and validated using Flatpak linter: 'flatpak run --command=flatpak-builder-lint org.flatpak.Builder appstream dev.brickstore.BrickStore.metainfo.xml' - Removed screenshots of BrickStore in other operating systems - Added a caption to the screenshot - Supplement <url's with sources, the translation page and bugtracker - Added a brand colors based on the app icon color: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/quality-guidelines#good-brand-colors
The FLATHUB_NETWORK_OFF option works _specifically_ *only* for Flatpak builds. It disables FetchContent used for QCoro, QAdwaitaDecorations & BuildSentry, and REQUIRES the sources for those to be in a specific "_deps" directory for the CMake build. These sources are provided in the Flatpak manifest for the build process.
8 tasks
Author
|
Sorry, forgot. Here is how the branding colors would look like using the Flathub preview. I chose it as recommended based on the icon color by simply lightening it up using a website, and then using a darker tint modified a bit more to contrast with the icon for the dark scheme. |
rgriebl
force-pushed
the
main
branch
4 times, most recently
from
July 27, 2026 23:45
7c44b29 to
a29ff85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request shows off some ready changes that would make it possible to submit the application to Flathub.
The idea and process I have described in issue #1057
For details, please refer to it.
Again, hoping this helps and is not too overwhelming all at once, it is only everything submitted at once since I have already done it and feel like it would be incomplete if I were to only suggest some parts first.
Feel free to give feedback and suggest any changes, I will quickly remedy them.
Some details I feel are worth mentioning:
appstreamcli validate --pedantic <file>andflatpak run --command=flatpak-builder-lint org.flatpak.Builder appstream <file>. I put exact details on each point into the commit description as well.FLATHUB_NETWORK_OFFoption is specifically built for a Flatpak build that pulls in QAdwaitaDecoration, QCoro and Sentry in respective directories under_deps/(as done in my suggested dev.brickstore.BrickStore.yml ).