fix: Make animated WebP emotes properly animate #1126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure to check the following tasks before opening and submitting a PR
Changes to Autumn several months ago created an issue where Revite will pull image previews for emotes instead of the emote image itself. This is fine for static emotes, but it causes issues specifically with animated WebP emotes (and perhaps static WebP emotes as well, though I haven't tested).
This PR fixes that by changing the URL used to fetch emotes, suffixing it with
/original. This bypasses the image preview entirely and fetches the real emote image data.An example of a broken emote with the current code (ID
01HY26VF5KMGAVMK14HPRDPWDT):The same emote, now animating properly:
