Use localStorage for emoji pack setting #1125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should use the proper settings sync system and not local storage, the setting is already properly synced however the |
|
Given the choice for other emojis isn't planned for the new clients, I don't see much issue with just using localStorage. |
|
I honestly didn't know sync was set up, I'm sorry. I for some reason assumed sync wasn't implemented. Should I leave it as it is or edit it to use sync? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure to check the following tasks before opening and submitting a PR
The emoji pack selector returned to default every time the page was reloaded. Added localStorage to the function that changes the pack globally to also save the change.
Fixes part of #1117