Skip to content

feat: add 'respect eof' option for reading from bounded sources #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tychoish
Copy link

@tychoish tychoish commented Mar 3, 2024

Sorry for not opening a pull request with this, I ended up running
into the obvious problem when reading from finite sources.

I'm happy to write tests for this though I wanted to see if you had
opinions on how to mock this out or handle it. (Or even if you were interested,)

@tychoish
Copy link
Author

tychoish commented Mar 4, 2024

This was a bad idea #5 solves the problem in a reasonable.

@tychoish tychoish closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant