build(npm): pin the three remaining caret ranges - #103
Merged
Conversation
Every dependency in the reqstool repos is pinned to an exact version except these three, which carried `^` ranges. A caret range means the version that gets installed depends on when you install -- CI, a laptop and a release build can each resolve differently, and a bad upstream release lands without a PR to review it. Pinned to what the lockfile already resolved, so nothing changes behaviourally: esbuild 0.28.2, eslint-config-prettier 10.1.8, prettier 3.9.6 -- all of which are also the current latest. Verified `npm ci`, `npm run lint` and the prettier check all still pass. Renovate keeps proposing upgrades as before; they now arrive as reviewable PRs rather than silently. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
Every dependency in the reqstool repos is now pinned to an exact version. A range means the version you get depends on when you install — CI, a laptop and a release build can each resolve differently — and a bad upstream release lands without a PR anyone reviewed.
Renovate keeps proposing upgrades exactly as before; they now arrive as reviewable PRs that CI has to pass, rather than silently.
Paired with reqstool/.github#77, which sets
rangeStrategy: "pin"org-wide so nothing drifts back.This repo
esbuild^0.28.00.28.2eslint-config-prettier^10.1.810.1.8prettier^3.8.33.9.6Pinned to what the lockfile already resolved, so nothing changes behaviourally — and all three happen to be the current latest, so this is a pin and a bump in one.
Verified locally:
npm ci,npm run lintand the prettier check all pass.