enable SSL for the SDK pod #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laverya
commented
Jun 6, 2025
…ble-ssl-for-replicated-sdk-pod
laverya
commented
Jun 6, 2025
Comment on lines
-62
to
+61
| docker push ttl.sh/${USER}/replicated-sdk:24h | ||
|
|
||
| make -C chart build-ttl.sh | ||
| dagger call test-chart --progress=plain |
There was a problem hiding this comment.
the files this used to use were deleted with the move to dagger
staciegravy
reviewed
Jun 6, 2025
| } | ||
|
|
||
| // loadTLSConfig loads TLS certificate and key from a Kubernetes secret | ||
| func loadTLSConfig(clientset kubernetes.Interface, namespace, secretName string) (*tls.Config, error) { |
There was a problem hiding this comment.
Should we do some certificate validation here? At least check the expiry?
There was a problem hiding this comment.
Honestly I don't think so? Is it better to fallback to non-tls, or is it better to just keep serving the provided certificate?
There was a problem hiding this comment.
Think im with @laverya on this one, I wouldn't be opposed to trying to emit debug lines if the cert was expired or something along those lines - but generally expect services to still start when the cert is expired/self-signed/etc i think.
pandemicsyn
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds SSL support for the pod, and adds a bunch of dagger logging + has the dagger test upgrade the chart to use SSL after initial installation + check that the pod is actually serving traffic via ssl
Does this PR introduce a user-facing change?