update the registry to point to new proxy endpoint #283
Conversation
staciegravy
force-pushed
the
staciegraves/sc-123590/update-sdk-to-pull-from-new-registry-proxy
branch
2 times, most recently
from
29f8e0a to
f2f8fd9
Compare
laverya
left a comment
laverya
left a comment
There was a problem hiding this comment.
This looks fine to me but I'm not the most familiar with the build code
| # If .Values.images is set, it takes precedence over the following settings. | ||
| image: | ||
| registry: registry.replicated.com # Registry where the image is hosted | ||
| registry: proxy.replicated.com # Registry where the image is hosted |
There was a problem hiding this comment.
👍 this is probably the most important one. This is the seed for the template.
| } | ||
|
|
||
| valuesYAML = strings.Replace(valuesYAML, "registry: registry.replicated.com", fmt.Sprintf("registry: %s", imageRegistry), 1) | ||
| valuesYAML = strings.Replace(valuesYAML, "registry: proxy.replicated.com", fmt.Sprintf("registry: %s", imageRegistry), 1) |
There was a problem hiding this comment.
This is the one that comes into play during the validate dagger cal (and the validate ci step). buildAndPushChartToTTL will get called with a imageRegistry val passed to it by the result of buildAndPushImageToTTL which has ttl.sh hard coded:
replicated-sdk/dagger/build.go
Line 28 in b33008f
There was a problem hiding this comment.
(just random notes for all of us)
There was a problem hiding this comment.
This needs to be changed like it is here.
staciegravy
force-pushed
the
staciegraves/sc-123590/update-sdk-to-pull-from-new-registry-proxy
branch
from
7f12251 to
a3d76aa
Compare
staciegravy
force-pushed
the
staciegraves/sc-123590/update-sdk-to-pull-from-new-registry-proxy
branch
from
a3d76aa to
f8941d1
Compare
There was a problem hiding this comment.
validate action looks right. I see proxy in https://github.com/replicatedhq/replicated-sdk/actions/runs/15544315359/job/43762284672#step:3:4775 and i see a replicated pod in the cluster.
240 : [11m3s] | NAME READY STATUS RESTARTS AGE
240 : [11m3s] | replicated-cbcc9cb9f-src94 1/1 Running 0 18s
240 : [11m3s] | replicated-ssl-test-65df659864-q7qbn 1/1 Running 0 14s
240 : [11m3s] | test-chart-5d94979fb7-txm7v 1/1 Running 0 44s
What does this PR do?
Update the registry to point to the new proxy endpoint. Then we will create a beta tag for 1.7.0-beta.1.
sc-123590
Does this PR introduce a user-facing change?
Testing
Locally I ran a kots install with the SDK subchart and made sure everything came up ok.