Skip to content

Conversation

emosbaugh
Copy link
Member

@emosbaugh emosbaugh commented Jun 12, 2025

What this PR does / why we need it:

Does not show host preflight error messages with flags in UI.

# output/bin/embedded-cluster install  --license local-dev/license-ethan.yaml  --admin-console-password password --http-proxy http://1.1.1.1:111 --https-proxy http://1.1.1.1:111 

✔  Initialization complete
✗  2 host preflights failed

 •  Error connecting to https://ec-e2e-replicated-app.testcluster.net. Ensure   
    your firewall is properly configured, and use --http-proxy, --https-proxy,  
    and --no-proxy if there is a proxy server. The static IP addresses for      
    https://ec-e2e-replicated-app.testcluster.net are 162.159.133.41 and        
    162.159.134.41.                                                             
 •  Error connecting to https://ec-e2e-proxy.testcluster.net. Ensure your       
    firewall is properly configured, and use --http-proxy, --https-proxy, and   
    --no-proxy if there is a proxy server. The static IP addresses for          
    https://ec-e2e-proxy.testcluster.net are 162.159.137.43 and 162.159.138.43. 


Please address these issues and try again.

ERROR: unable to run install preflights: host preflight failures detected
Screenshot 2025-06-12 at 5 55 21 AM

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?


Does this PR require documentation?

Copy link

github-actions bot commented Jun 12, 2025

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-d8792b9" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-d8792b9?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

@emosbaugh emosbaugh marked this pull request as ready for review June 12, 2025 13:24
@emosbaugh emosbaugh force-pushed the emosbaugh/sc-124823/different-preflight-failure-messaging-for branch from cc72ce5 to 91b94fb Compare June 13, 2025 21:15
@@ -31,6 +31,10 @@ type Controller interface {
GetStatus(ctx context.Context) (*types.Status, error)
}

type RunHostPreflightsOptions struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be better to move this to a types package

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should discuss the types package. Maybe break it up. I had the understanding that it was for api types (eg request response), not controller and manager options.

https://github.com/replicatedhq/embedded-cluster/pull/2300/files#diff-f62a0fad1ad21e2ffa9cf4de2cab02d8a2dccd2557065c737942d54e9a1ed736R3

@emosbaugh emosbaugh merged commit 3d327a3 into main Jun 16, 2025
146 of 150 checks passed
@emosbaugh emosbaugh deleted the emosbaugh/sc-124823/different-preflight-failure-messaging-for branch June 16, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants