Skip to content

Fix "new version available" prompt appearing after manager experience URL #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

Fix "new version available" prompt appearing after manager experience URL #2244

merged 1 commit into from
Jun 10, 2025

Conversation

screspod
Copy link
Member

@screspod screspod commented Jun 4, 2025 •
edited
Loading

What this PR does / why we need it:

User sees the prompt about a new available version after the prompt to go to the UI.
This PR fixes that behavior and reorganizes similar prompts and checks to enhance the user experience.

New priority Order

  1. Cobra's required flag validation (e.g. missing --license)
  2. Prompts and checks on installation state, license file, airgap bundles, and releases
    • Existing k0s installation (reinstall detected)
    • Airgap bundle downloaded but not provided via CLI
    • License/release version mismatch
    • Airgap bundle/release version mismatch
    • Outdated release version available
  3. Proxy configuration prompt (HTTP proxy set without HTTPS)
  4. Admin console password prompt
  5. Display URL to the Manager Experience UI

Which issue(s) this PR fixes:

https://app.shortcut.com/replicated/story/124485/user-sees-the-prompt-about-a-new-available-version-after-the-prompt-to-go-to-the-ui

Does this PR require a test?

NONE

Does this PR require a release note?

NONE

Does this PR require documentation?

NONE

@screspod screspod changed the title Fix new version prompt showing after manager experience URL Fix "new version available" prompt showing after the manager experience UI URL Jun 4, 2025
@screspod screspod changed the title Fix "new version available" prompt showing after the manager experience UI URL Fix "new version available" prompt showing after the URL to the manager experience Jun 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025 •
edited
Loading

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-20c336c" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-20c336c?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

@screspod screspod changed the title Fix "new version available" prompt showing after the URL to the manager experience Fix "new version available" prompt appearing after manager experience URL Jun 4, 2025
@screspod screspod force-pushed the screspod/sc-124485/fix-new-version-prompt-order branch 4 times, most recently from 449115c to 3a285b0 Compare June 6, 2025 17:08
@screspod screspod marked this pull request as ready for review June 6, 2025 18:26
@screspod screspod force-pushed the screspod/sc-124485/fix-new-version-prompt-order branch from 3a285b0 to b898b0e Compare June 10, 2025 15:41
sgalsaleh
sgalsaleh reviewed Jun 10, 2025
View reviewed changes
cmd/installer/cli/install.go Outdated
@@ -281,6 +284,17 @@ func preRunInstall(cmd *cobra.Command, flags *InstallCmdFlags, rc runtimeconfig.

flags.isAirgap = flags.airgapBundle != ""

proxy, err := parseProxyFlags(cmd)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't want to verify proxy flags or prompt if it's the new manager experience flag. this should go in the else below

Copy link
Member Author

@screspod screspod Jun 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression that we would eventually populate the UI with the CLI flags from a previous conversation with @jtuchscherer, but from today it seems that is not the plan anymore. Just documenting that I will move this back into the manager experience conditional in order to prompt the user only when the manager experience flag is not provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are correct, @screspod . I think today's discussion changed the direction on this

@screspod screspod force-pushed the screspod/sc-124485/fix-new-version-prompt-order branch from b898b0e to 20c336c Compare June 10, 2025 20:09
@screspod screspod merged commit 7f68707 into main Jun 10, 2025
65 checks passed
@screspod screspod deleted the screspod/sc-124485/fix-new-version-prompt-order branch June 10, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtuchscherer jtuchscherer jtuchscherer left review comments

@sgalsaleh sgalsaleh sgalsaleh approved these changes

Assignees
No one assigned
Labels
bug::normal type::bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@screspod @jtuchscherer @sgalsaleh