-
Notifications
You must be signed in to change notification settings - Fork 22
Fix unsupported network detection and UI handling #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Fix unsupported network detection and UI handling #351
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
|
|
It is also good to open the Unsupported Network view as soon as we notice the case. Dont wait til the user presses the network button |
Co-Authored-By: [email protected] <[email protected]>
…supported Co-Authored-By: [email protected] <[email protected]>
…session to settle
|
Fix Unsupported Network Detection and UI Handling
Issue
When a developer sets one network (e.g., Polygon Amoy) but wallets approve additional networks in "approvedNamespaces", AppKit doesn't properly handle this case, causing issues when the active chain is not in the requested networks list.
Changes
isActiveNetworkInRequestedNetworks()
method to NetworkController to check if the active network is in the requested networks listTesting
isActiveNetworkInRequestedNetworks()
methodLink to Devin run
https://app.devin.ai/sessions/124d739794074b339654fedc48a576d7
Requested by: [email protected]