Integrate Rocq checker into CI #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensimner
force-pushed
the
wip-rocq-ci
branch
3 times, most recently
from
bab7ef5 to
f459305
Compare
febyeji
approved these changes
Apr 17, 2025
| runmsg("CHECK", test_name) | ||
|
|
||
| expected_status = expected_log.read_text().strip().splitlines()[-1] | ||
| expected_status = 121 if expected_status.startswith("!") else 0 |
There was a problem hiding this comment.
This looks good for now, but maybe we can enhance the code later to check whether the error messages from the failing tests align with the expected errors.
There was a problem hiding this comment.
Ideally, we are going to end up with multiple implementations (in-kernel runtime check, out-of-kernel-but-still-C checker and the rocq-extracted-to-ocaml checker) and want some way to check correspondence between them.
Perhaps (not in this PR) we should give all the violations some error codes, like linters do, e.g.:
E01 - BBM Vioaltion
E02 - Race on PTE
etc
Then we can check that it fails with the same code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
(1) made the Rocq command-line pass an exit code out, so one can programmatically detect failures
(2) added a
make check-rocqtop-level target that runs all the examples over the rocq thing(3) make the CI init opam and install casemate-rocq into it and run that target, based on cerberus' CI.