feat: Support nested fieldset conditionals #156
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcardoso5
force-pushed
the
fix-nested-fieldset-conditional
branch
from
d36362a to
83afe41
Compare
remotecom
force-pushed
the
fix-nested-fieldset-conditional
branch
from
83afe41 to
26b4682
Compare
ollyd
previously approved these changes
Apr 15, 2025
danielcardoso5
force-pushed
the
fix-nested-fieldset-conditional
branch
2 times, most recently
from
83813f2 to
de844d0
Compare
danielcardoso5
force-pushed
the
fix-nested-fieldset-conditional
branch
from
de844d0 to
6535096
Compare
This reverts commit 5e60e24.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings support for conditionals that affect nested fieldset fields. It ensures their conditional display (reported by
isVisible) and validation logic works correctly.This focuses on v0 version of json-schema-form. Some issues were also identified with v1, they'll be fixed on an upcoming PR.
Here are examples of the differences between current functionality and the one introduced, using the
schemaWithNestedFieldsetsConditionalsschema used in the tests. Note that theRetirement planis conditionally required based on theHas retirement plan?selection, and so, should not appear by default.Screenshots
As visible in the screenshots, the default visibility of the nested fieldset didn't take into account the existing conditional logic.
chore: includes changes to fix the build script for v0 and
lint-stagedscript