This repository was archived by the owner on Jun 13, 2019. It is now read-only.
Open
Conversation
Owner
|
You have the same PR twice. Can you correct that before merging? |
Contributor
Author
|
Oops! I was working on two features and didn't switch branch :( PR 44 has all my changes. Lets chat on PR 44. |
Contributor
Author
|
I think, I know why. PR 43 & 44 are connected. 44 is built on top of 43. That's why 44 showing same commits of 43. So, you can accept just 43 and not 44. If you prefer to work on one PR in this case then I will close PR 43. Please let me know if this makes sense. |
Contributor
Author
|
@Liman123 That's great. I am sure this is awesome tool. I have already got 4 messages from you. so please stop spamming my inbox. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I have added option to use Dotzu without Bubble Head and configure LogSettings programmatically.
Why?
Summary of changes:
Notes:
** I am working on another PR, which adds more options to LogSettings and it may get cumbersome to maintain.
Thanks a lot for your time.
Cheers!