Skip to content

Conversation

@1-leo
Copy link
Contributor

@1-leo 1-leo commented Dec 3, 2025

related to #319

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 82.03125% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.87%. Comparing base (f053c29) to head (f368849).
⚠️ Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...kages/ndk/lib/shared/isolates/isolate_manager.dart 72.41% 16 Missing ⚠️
...s/ndk/lib/domain_layer/usecases/relay_manager.dart 88.57% 4 Missing ⚠️
.../lib/shared/decode_nostr_msg/decode_nostr_msg.dart 90.90% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
+ Coverage   70.83%   70.87%   +0.03%     
==========================================
  Files         136      139       +3     
  Lines        5051     5157     +106     
==========================================
+ Hits         3578     3655      +77     
- Misses       1473     1502      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@1-leo
Copy link
Contributor Author

1-leo commented Dec 5, 2025

@1-leo 1-leo self-assigned this Dec 6, 2025
@1-leo 1-leo added the enhancement New feature or request label Dec 6, 2025
@1-leo 1-leo added this to ndk-dev Dec 6, 2025
@1-leo 1-leo moved this to In Progress in ndk-dev Dec 6, 2025
@1-leo 1-leo marked this pull request as ready for review December 22, 2025 12:32
@frnandu
Copy link
Collaborator

frnandu commented Dec 22, 2025

don't forget to also replace Nip46EventSigner jsonDecode usage with isolate

@frnandu
Copy link
Collaborator

frnandu commented Dec 22, 2025

libs to maybe try if it makes sense for our pool management requirements:

@frnandu frnandu added this to the 0.7 milestone Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants