Skip to content

Conversation

@nogringo
Copy link
Collaborator

No description provided.

@nogringo nogringo requested review from 1-leo and frnandu October 19, 2025 14:22
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.52%. Comparing base (056caf8) to head (d4b7d3f).
⚠️ Report is 181 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #244   +/-   ##
=======================================
  Coverage   71.52%   71.52%           
=======================================
  Files         125      125           
  Lines        4400     4400           
=======================================
  Hits         3147     3147           
  Misses       1253     1253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@1-leo 1-leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good starting point.
I think the widgets could be more configurable, providing default options and taking params to change the style etc.

  • docs for the params

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can the user extend language files?
A example on how this could work might be nice. (or sample app)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way that does not require our input?

child: PrettyQrView.data(
data: nostrConnectURL,
decoration: const PrettyQrDecoration(
shape: PrettyQrShape.custom(PrettyQrDotsSymbol()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config options (param)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add cutomisation in the future

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for dependencies like secure storage, crypto etc it might make sense to use version ranges to increase compatibility with the developers packages

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do it ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed it, please check if it works for you

@nogringo nogringo requested a review from 1-leo October 20, 2025 16:05
@1-leo 1-leo moved this to In Progress in ndk-dev Nov 11, 2025
@1-leo 1-leo added this to ndk-dev Nov 11, 2025
@1-leo 1-leo added enhancement New feature or request help wanted Extra attention is needed labels Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request help wanted Extra attention is needed

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants