-
Notifications
You must be signed in to change notification settings - Fork 5
Ndk flutter #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Ndk flutter #244
Conversation
NPicture use the metadata pubkey if present
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #244 +/- ##
=======================================
Coverage 71.52% 71.52%
=======================================
Files 125 125
Lines 4400 4400
=======================================
Hits 3147 3147
Misses 1253 1253 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1-leo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good starting point.
I think the widgets could be more configurable, providing default options and taking params to change the style etc.
- docs for the params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how can the user extend language files?
A example on how this could work might be nice. (or sample app)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way that does not require our input?
| child: PrettyQrView.data( | ||
| data: nostrConnectURL, | ||
| decoration: const PrettyQrDecoration( | ||
| shape: PrettyQrShape.custom(PrettyQrDotsSymbol()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config options (param)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add cutomisation in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for dependencies like secure storage, crypto etc it might make sense to use version ranges to increase compatibility with the developers packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed it, please check if it works for you
No description provided.