Hydrate settled amounts + add onTransactionReceived#946
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pedromcunha
requested changes
Feb 19, 2026
| ) | ||
| .then((data) => { | ||
| resolve({ data, abortController }) | ||
| void hydrateTransactionMetadataAndNotify({ |
Member
There was a problem hiding this comment.
do we need this void here? Seems odd
| } | ||
| } | ||
|
|
||
| async function hydrateTransactionMetadataAndNotify({ |
Member
There was a problem hiding this comment.
Hydrate feels like a strange word placement here. What we're doing feels more like enriching
| } | ||
| } | ||
|
|
||
| async function pollRequestById( |
Member
There was a problem hiding this comment.
I believe we do this today somewhere, maybe the ui client. Do we no longer need to do that in the ui and instead pass it up to the swapwidget/tokenwidget?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.