Migration to lutaml-model#22
Draft
andrew2net wants to merge 39 commits into
Draft
Conversation
…roup, and enhance contributor handling
Enhance DataFetcher and Parser with error handling and logging features - Implement `gh_issue_channel` and `log_error` methods in DataFetcher. - Modify Parser to accept an errors hash and update parsing methods to track errors. - Update tests to cover new functionality and ensure error handling works as expected.
Each integration test loads and parses index file. This slows down the tests and creates huge VCRs
…release classes (#24)
…for 2.1.0 release
3GPP now sits behind Cloudflare, which does not proxy FTP. Port 21 is unreachable on every Cloudflare address, breaking the scheduled crawler with Errno::ENETUNREACH. Switch DataFetcher#get_file to a Net::HTTP HEAD+GET against https://www.3gpp.org/ftp/Information/Databases/3GPPBibliography.csv and use the Last-Modified header for change detection. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Some rows in the upstream CSV have an empty Responsible Secondary column. Calling .strip on it raises NoMethodError and aborts the whole crawler run. Mirror the nil/empty guard already present in prime_contribs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3GPP's published CSV is now ;-delimited (was comma). Without col_sep the entire row collapses into the first column, blowing up later as either parser errors or ENAMETOOLONG when the docnumber-derived filename embeds the whole row. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.