test(web): test fix #1616
Open
test(web): test fix #1616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-cms ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request standardizes TypeScript import declarations across E2E test files by converting runtime imports to type-only imports for the Playwright Page interface.
- Updates import syntax from
import { Page }toimport type { Page }for TypeScript type-only imports - Applies the change consistently across 12 E2E test utility files and test specification files
- Improves TypeScript compilation efficiency by explicitly marking type-only imports
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| web/e2e/utils/viewer.ts | Changed Page import to type-only import |
| web/e2e/project/utils/workspace.ts | Changed Page import to type-only import |
| web/e2e/project/utils/project.ts | Changed Page import to type-only import |
| web/e2e/project/utils/model.ts | Changed Page import to type-only import |
| web/e2e/project/utils/item.ts | Changed Page import to type-only import |
| web/e2e/project/utils/group.ts | Changed Page import to type-only import |
| web/e2e/project/utils/field.ts | Changed Page import to type-only import |
| web/e2e/project/utils/comment.ts | Changed Page import to type-only import |
| web/e2e/project/schema.spec.ts | Changed Page import to type-only import |
| web/e2e/project/content/view.spec.ts | Changed Page import to type-only import |
| web/e2e/project/asset/asset.spec.ts | Changed Page import to type-only import |
| web/e2e/common/notification.ts | Changed Page import to type-only import |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
🚀 Cloud Run Preview Deployed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
What I haven't done
How I tested
Screenshot
Which point I want you to review particularly
Memo