-
Notifications
You must be signed in to change notification settings - Fork 386
RI-7195: Add search screen #4788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RI-7195: Add search screen #4788
Conversation
Code Coverage - Frontend unit tests
Test suite run success4923 tests passing in 650 suites. Report generated by 🧪jest coverage report action from ceb38aa |
redisinsight/ui/src/components/query/query-lite-actions/QueryLiteActions.tsx
Outdated
Show resolved
Hide resolved
a57abf3
to
872aefb
Compare
872aefb
to
e9ebec0
Compare
...sinsight/ui/src/pages/vector-search/components/commands-view/CommandsView/styles.module.scss
Show resolved
Hide resolved
redisinsight/ui/src/pages/vector-search/components/commands-view/CommandsViewWrapper.tsx
Outdated
Show resolved
Hide resolved
redisinsight/ui/src/pages/vector-search/query/VectorSearchQuery.tsx
Outdated
Show resolved
Hide resolved
e9ebec0
to
afaf8c4
Compare
Code Coverage - Integration Tests
|
Code Coverage - Backend unit tests
Test suite run success2948 tests passing in 286 suites. Report generated by 🧪jest coverage report action from 71bcb66 |
<QueryWrapper | ||
query={query} | ||
activeMode={activeMode} | ||
resultsMode={resultsMode} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether it's an issue with the way I test it, but I've noticed the following issue.
If we run queries on the Workbench page, I see a button with the option to toggle the way we display the results - via text, or render them in a table.

However, when I go to the new Vector Search page and run a query, I don't see the button for toggling the view.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is intended - the designs use a very lite version of that component (the one that displays the command + the controls for it - re-reun, delete, expand, etc..). So I just copied the one from the workbench and disabled some stuff - the view type changer + profile button. If you see the last methods of the useQuery
hook - we don't support them at all for this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the information. I asked because we have telemetry events planned for these buttons, and SEARCH_RESULT_VIEW_CHANGED
is also included. Anyway, if it's not part of the design, I can omit this one for now, and cover the rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall the useQuery hook seems really complex, it lacks tests as well
can it be restructured/split in a way or the functionality has to be together?
loadHistory() | ||
}, [instanceId]) | ||
|
||
const prepareNewItems = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can extract from hook
This PR introduces the
Search
screen, which is intended to be displayed when there are existing indexes.Since the functionality is quite similar to Workbench, I attempted to reuse some of its logic. However, due to structural differences, full reuse isn't straightforward at this stage. Here's a breakdown of what's included in this change:
Note: Unit tests are not included in this PR but will be added later in the flow once the behavior stabilizes.
If you want to test with the provided data, use these commands:
FT.SEARCH idx:bikes_vss "@brand:Nord" SORTBY price ASC
FT.SEARCH idx:bikes_vss "@material:{alloy} @weight:[0 20]"