Skip to content
This repository was archived by the owner on Apr 16, 2025. It is now read-only.

Conversation

@Jdubrick
Copy link
Contributor

@Jdubrick Jdubrick commented Apr 15, 2025

This PR performs the following steps in preparation for archiving this repository:

  • Add warning to main readme outlining the deprecation.
  • Remove contributing instructions and issue opening instructions.

resolves devfile/api#1682

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jdubrick Should remove all references to weekly schedule on Wednesdays as well.

Co-authored-by: Michael Valdron <[email protected]>
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jdubrick These lines should also be revised to remove the Wednesday schedule from them.

Nit suggestion: I notice the .ci/build.sh fails when I run it, though it is not required I feel it would be great to pin the registry-support reference, such as devfile/registry-support@4bc237b, so if it does work on a previous state someone can still build the image. I would say only do this if its an easy change otherwise I won't block this PR due to this.

Signed-off-by: Jordan Dubrick <[email protected]>
@Jdubrick
Copy link
Contributor Author

@Jdubrick These lines should also be revised to remove the Wednesday schedule from them.

Nit suggestion: I notice the .ci/build.sh fails when I run it, though it is not required I feel it would be great to pin the registry-support reference, such as devfile/registry-support@4bc237b, so if it does work on a previous state someone can still build the image. I would say only do this if its an easy change otherwise I won't block this PR due to this.

I updated the readme and pinned the commit, I had to force the checkout but the collisions were in vendor file readme files so I think it's alright. If we don't want to do that I can revert it, fyi @michael-valdron

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build seems to work now 😄

Just the one comment I have left and should be good to merge.

Signed-off-by: Jordan Dubrick <[email protected]>
Co-authored-by: Michael Valdron <[email protected]>
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 16, 2025
@michael-valdron michael-valdron merged commit ab6c51d into redhat-developer:main Apr 16, 2025
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Archive the product registry repo

2 participants