Draft
Bump controller-runtime from v0.22.4 to v0.23.3#240
Conversation
- Update sigs.k8s.io/controller-runtime from v0.22.4 to v0.23.3 - Update k8s.io/* dependencies from v0.34.x to v0.35.0 - Update Go version from 1.24.2 to 1.25.0 (required by controller-runtime v0.23.3) - Update ENVTEST_VERSION from release-0.19 to release-0.23 in Makefile - Remove unnecessary cel-go replace directive - Update vendor directory Co-authored-by: vinamra28 <26500025+vinamra28@users.noreply.github.com> Agent-Logs-Url: https://github.com/redhat-data-and-ai/usernaut/sessions/bfe023a6-ba13-4502-9f76-bd9e9c5ecec2
Copilot
AI
changed the title
[WIP] Update controller-runtime dependency to v0.23.3
Bump controller-runtime from v0.22.4 to v0.23.3
Mar 24, 2026
Member
|
@copilot CI seems to be failing, can you please take a look and fix? |
…ility controller-gen v0.16.1 depends on golang.org/x/tools@v0.24.0 which fails to compile with Go 1.25.0 due to a negative array length bug. controller-tools v0.20.1 is the matching version for k8s.io/* v0.35.0 and uses a compatible golang.org/x/tools version. Co-authored-by: vinamra28 <26500025+vinamra28@users.noreply.github.com> Agent-Logs-Url: https://github.com/redhat-data-and-ai/usernaut/sessions/4cfd031e-ca7d-4e13-aa93-54c06922c7b3
Author
The CI failure was caused by Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Member
|
@copilot there seems to be merge conflicts as the current branch is behind main. Fix the conflicts and make sure that nothing breaks. |
Resolve conflicts in go.mod, go.sum, and vendor/modules.txt by keeping k8s.io/* v0.35.0 and controller-runtime v0.23.3 versions (required by this PR's upgrade) while incorporating all other changes from main: - Handle user creation having '-' in username (snowflake) - Bump go-ldap from 3.4.12 to 3.4.13 - Bump miniredis from 2.36.1 to 2.37.0 - Bump heimdall from 7.0.3 to 7.1.0 - Bump go-redis from 9.17.x to 9.18.0 - Bump k8s.io/apimachinery and client-go from 0.34.4 to 0.34.6 Added exclude directives for github.com/smartystreets/assertions v1.14.0+ as those versions changed their module path to github.com/smarty/assertions, breaking the transitive dependency through hystrix-go -> goconvey -> assertions. Co-authored-by: vinamra28 <26500025+vinamra28@users.noreply.github.com>
Author
Merged main into the branch at Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Member
|
@copilot, bruh, there are 4 commits, squash them and have a single commit which explains what we are trying to do. |
Author
Squashing requires a force push (history rewrite), which I'm unable to perform in this environment. Please use GitHub's "Squash and merge" option when merging the PR — it will automatically squash all commits into one with the PR title as the commit message. The end result on Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original prompt
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.