Skip to content

Conversation

jkopriva
Copy link
Contributor

@jkopriva jkopriva commented Aug 5, 2025

Summary by CodeRabbit

  • Chores
    • Updated subscription and channel values used during pre-release setup.
    • Changed the path to the subscription values file for improved configuration handling.

@openshift-ci openshift-ci bot requested review from prietyc123 and xinredhat August 5, 2025 08:21
@jkopriva jkopriva requested a review from Roming22 August 5, 2025 08:21
Copy link

sonarqubecloud bot commented Aug 5, 2025

Copy link

coderabbitai bot commented Aug 5, 2025

Walkthrough

The hack/pre-release.sh script was updated to change the subscription name and channel used in the configure_rhdh function, and to update the YAML path in the configure_subscription function. No changes were made to exported or public entity signatures.

Changes

Cohort / File(s) Change Summary
Pre-release Script Subscription Updates
hack/pre-release.sh
Updated subscription name from "redHatDeveloperHub" to "developerHub", channel from "fast-1.6" to "fast-1.7", and changed the YAML path in configure_subscription from installer/charts/rhtap-subscriptions/values.yaml to installer/charts/tssc-subscriptions/values.yaml.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant pre-release.sh
    participant SubscriptionConfig
    participant YAMLFile

    User->>pre-release.sh: Run pre-release script
    pre-release.sh->>SubscriptionConfig: configure_rhdh("developerHub", "fast-1.7")
    pre-release.sh->>SubscriptionConfig: configure_subscription("installer/charts/tssc-subscriptions/values.yaml")
    SubscriptionConfig->>YAMLFile: Apply changes using updated values
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5-10 minutes

Possibly related PRs

Suggested labels

approved, lgtm

Poem

A script now tuned for channels new,
With YAML paths that point anew.
Subscriptions swapped, the hub aligned,
Pre-release steps are now refined.
🐇 Bashful bunny hops in delight,
For everything’s set up just right!

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11ca366 and 1902cce.

📒 Files selected for processing (1)
  • hack/pre-release.sh (2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: for the rhtap-cli repository, chart version bumps in helm charts are handled at release time, not wh...
Learnt from: Roming22
PR: redhat-appstudio/rhtap-cli#1000
File: installer/charts/tssc-gitops/Chart.yaml:6-7
Timestamp: 2025-07-07T15:41:17.668Z
Learning: For the rhtap-cli repository, chart version bumps in Helm charts are handled at release time, not when appVersion is updated during development. The team follows a workflow where appVersion can be updated in PRs but the chart version field is only incremented during the release process.

Applied to files:

  • hack/pre-release.sh
📚 Learning: for the rhtap-cli project, chart versions in helm charts are updated during release time rather than...
Learnt from: Roming22
PR: redhat-appstudio/rhtap-cli#1000
File: installer/charts/tssc-pipelines/Chart.yaml:6-7
Timestamp: 2025-07-07T15:41:20.050Z
Learning: For the rhtap-cli project, chart versions in Helm charts are updated during release time rather than with every individual change to the appVersion field.

Applied to files:

  • hack/pre-release.sh
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Red Hat Konflux / rhtap-cli-on-pull-request
🔇 Additional comments (1)
hack/pre-release.sh (1)

119-129: Ensure the new developerHub key actually exists in values.yaml and matches the operator’s channel

Changing SUBSCRIPTION to developerHub and CHANNEL to fast-1.7 will only work if
installer/charts/tssc-subscriptions/values.yaml already contains
.subscriptions.developerHub with a matching channel entry.
Historically the key was redHatDeveloperHub; if the YAML was not updated in the same PR,
yq will silently create a brand-new node and the operator will never be upgraded.

Please verify the file contains the correct structure, e.g.

subscriptions:
  developerHub:
    channel: fast-1.7
    source: rhdh-fast

If the key is different, either revert the variable or align the YAML accordingly.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@Roming22 Roming22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkopriva, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 2742438 into redhat-appstudio:main Aug 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants