Skip to content

Conversation

rh-tap-build-team[bot]
Copy link
Contributor

Promote from stage to production

@openshift-ci openshift-ci bot requested review from FernandesMF and qixiang August 21, 2025 08:12
Copy link
Contributor

Code Review by Gemini

--- a/components/mintmaker/production/base/kustomization.yaml
+++ b/components/mintmaker/production/base/kustomization.yaml
@@ -4,16 +4,16 @@
 # See https://kustomize.io/docs/reference/kustomization-file/
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 
 resources:
-  - https://github.com/konflux-ci/mintmaker/config/renovate?ref=3251d8a71d835d209f609f33b10a3091ad5ca8b3
+  - https://github.com/konflux-ci/mintmaker/config/renovate?ref=<NEW_REF>
 
 namespace: mintmaker
 
 images:
   - name: quay.io/konflux-ci/mintmaker
     newName: quay.io/konflux-ci/mintmaker
-    newTag: 3251d8a71d835d209f609f33b10a3091ad5ca8b3
+    newTag: <NEW_TAG>
   - name: quay.io/konflux-ci/mintmaker-renovate-image
     newName: quay.io/konflux-ci/mintmaker-renovate-image
     newTag: 2720afb01917c617eda2fb3deea8f1937f4628b6

Consider if the ref for https://github.com/konflux-ci/mintmaker/config/renovate and the newTag for quay.io/konflux-ci/mintmaker should also be updated. If the "mintmaker" component promotion implies a new version for all its related parts, these values should be aligned with the new version being promoted to production.

@rh-tap-build-team rh-tap-build-team bot force-pushed the stage-to-prod-mintmaker branch from fd8a37d to c0109c6 Compare August 21, 2025 10:48
Copy link
Contributor

Code Review by Gemini

The changes in this pull request correctly update the Kustomize configuration for the mintmaker component to promote it to production.

The following lines were changed to update the component versions:

--- a/components/mintmaker/production/base/kustomization.yaml
+++ b/components/mintmaker/production/base/kustomization.yaml
@@ -1,27 +1,27 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 resources:
   - ../../base
   - ../../base/external-secrets
-  - https://github.com/konflux-ci/mintmaker/config/default?ref=3251d8a71d835d209f609f33b10a3091ad5ca8b3
-  - https://github.com/konflux-ci/mintmaker/config/renovate?ref=3251d8a71d835d209f609f33b10a3091ad5ca8b3
+  - https://github.com/konflux-ci/mintmaker/config/default?ref=adac7a3cf0a7b7355b84754a15d411de155b2b2d
+  - https://github.com/konflux-ci/mintmaker/config/renovate?ref=adac7a3cf0a7b7355b84754a15d411de155b2b2d
 
 namespace: mintmaker
 
 images:
   - name: quay.io/konflux-ci/mintmaker
     newName: quay.io/konflux-ci/mintmaker
-    newTag: 3251d8a71d835d209f609f33b10a3091ad5ca8b3
+    newTag: adac7a3cf0a7b7355b84754a15d411de155b2b2d
   - name: quay.io/konflux-ci/mintmaker-renovate-image
     newName: quay.io/konflux-ci/mintmaker-renovate-image
-    newTag: ff2257a000a23ba6f898bd136b8653feeff5b38f
+    newTag: 2720afb01917c617eda2fb3deea8f1937f4628b6
 
 commonAnnotations:
   argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true
 
 patches:
   - path: pipelines-as-code-secret-patch.yaml
     target:
       name: pipelines-as-code-secret
       kind: ExternalSecret
       group: external-secrets.io

Observations:

  • The mintmaker component's Kustomize base references and its image tag (quay.io/konflux-ci/mintmaker) have been consistently updated to adac7a3cf0a7b7355b84754a15d411de155b2b2d.
  • The mintmaker-renovate-image tag has been updated to 2720afb01917c617eda2fb3deea8f1937f4628b6.

The changes are consistent with a version promotion and appear correct. No issues or bugs were found in the provided diff.

@rh-tap-build-team rh-tap-build-team bot force-pushed the stage-to-prod-mintmaker branch from 6c501f9 to fb69121 Compare August 25, 2025 07:30
Copy link
Contributor

Code Review by Gemini

The changes in components/mintmaker/production/base/kustomization.yaml are consistent with promoting the mintmaker component to production by updating the Git SHAs for the configuration resources and the image tags.

No bugs or issues were found in the provided code changes.

Improvements:

  • Consistency of SHAs:
    It is good practice, as demonstrated in this change, to ensure that the ref for the mintmaker configuration (lines 6-7) and the newTag for the quay.io/konflux-ci/mintmaker image (line 14) are updated to the same SHA. This ensures that the deployed application configuration aligns with the specific image version.

@rh-tap-build-team rh-tap-build-team bot force-pushed the stage-to-prod-mintmaker branch from 954602a to 9fc6ee1 Compare August 25, 2025 07:36
Copy link

openshift-ci bot commented Aug 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rh-tap-build-team[bot]

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Code Review by Gemini

The provided diff is empty, indicating that no code changes were made in this pull request. Therefore, there is no code to review for bugs or suggest improvements.

If this pull request is intended to promote a component, it typically involves changes to configuration files, deployment scripts, or version numbers within the codebase. Please ensure that all relevant changes are included in the diff.

If this PR is solely for tracking a deployment event that is managed outside of code changes (e.g., via a CI/CD pipeline trigger), then the empty diff is expected, but there's no code to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants