-
Notifications
You must be signed in to change notification settings - Fork 306
Promoting component mintmaker from stage to prod #7760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code Review by Gemini--- a/components/mintmaker/production/base/kustomization.yaml
+++ b/components/mintmaker/production/base/kustomization.yaml
@@ -4,16 +4,16 @@
# See https://kustomize.io/docs/reference/kustomization-file/
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- - https://github.com/konflux-ci/mintmaker/config/renovate?ref=3251d8a71d835d209f609f33b10a3091ad5ca8b3
+ - https://github.com/konflux-ci/mintmaker/config/renovate?ref=<NEW_REF>
namespace: mintmaker
images:
- name: quay.io/konflux-ci/mintmaker
newName: quay.io/konflux-ci/mintmaker
- newTag: 3251d8a71d835d209f609f33b10a3091ad5ca8b3
+ newTag: <NEW_TAG>
- name: quay.io/konflux-ci/mintmaker-renovate-image
newName: quay.io/konflux-ci/mintmaker-renovate-image
newTag: 2720afb01917c617eda2fb3deea8f1937f4628b6 Consider if the |
fd8a37d
to
c0109c6
Compare
Code Review by GeminiThe changes in this pull request correctly update the Kustomize configuration for the The following lines were changed to update the component versions: --- a/components/mintmaker/production/base/kustomization.yaml
+++ b/components/mintmaker/production/base/kustomization.yaml
@@ -1,27 +1,27 @@
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- ../../base
- ../../base/external-secrets
- - https://github.com/konflux-ci/mintmaker/config/default?ref=3251d8a71d835d209f609f33b10a3091ad5ca8b3
- - https://github.com/konflux-ci/mintmaker/config/renovate?ref=3251d8a71d835d209f609f33b10a3091ad5ca8b3
+ - https://github.com/konflux-ci/mintmaker/config/default?ref=adac7a3cf0a7b7355b84754a15d411de155b2b2d
+ - https://github.com/konflux-ci/mintmaker/config/renovate?ref=adac7a3cf0a7b7355b84754a15d411de155b2b2d
namespace: mintmaker
images:
- name: quay.io/konflux-ci/mintmaker
newName: quay.io/konflux-ci/mintmaker
- newTag: 3251d8a71d835d209f609f33b10a3091ad5ca8b3
+ newTag: adac7a3cf0a7b7355b84754a15d411de155b2b2d
- name: quay.io/konflux-ci/mintmaker-renovate-image
newName: quay.io/konflux-ci/mintmaker-renovate-image
- newTag: ff2257a000a23ba6f898bd136b8653feeff5b38f
+ newTag: 2720afb01917c617eda2fb3deea8f1937f4628b6
commonAnnotations:
argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true
patches:
- path: pipelines-as-code-secret-patch.yaml
target:
name: pipelines-as-code-secret
kind: ExternalSecret
group: external-secrets.io Observations:
The changes are consistent with a version promotion and appear correct. No issues or bugs were found in the provided diff. |
6c501f9
to
fb69121
Compare
Code Review by GeminiThe changes in No bugs or issues were found in the provided code changes. Improvements:
|
954602a
to
9fc6ee1
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rh-tap-build-team[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Code Review by GeminiThe provided diff is empty, indicating that no code changes were made in this pull request. Therefore, there is no code to review for bugs or suggest improvements. If this pull request is intended to promote a component, it typically involves changes to configuration files, deployment scripts, or version numbers within the codebase. Please ensure that all relevant changes are included in the diff. If this PR is solely for tracking a deployment event that is managed outside of code changes (e.g., via a CI/CD pipeline trigger), then the empty diff is expected, but there's no code to review. |
Promote from stage to production