Skip to content

Conversation

sadlerap
Copy link
Contributor

Once we've removed the member-operator deployments, we can remove the rest of the resources managed by the member-operator component in argo except for the namespace.

Once we've removed the member-operator deployments, we can remove the
rest of the resources managed by the member-operator component in argo
except for the namespace.

Signed-off-by: Andy Sadler <[email protected]>
@sadlerap
Copy link
Contributor Author

/hold

Copy link
Contributor

Code Review by Gemini

The changes align with the stated goal of removing member components while retaining the namespace. No bugs or immediate issues are identified within the provided diff.

The modification to kustomization.yaml correctly removes the dependency on the base resources and the specific patch for the Subscription, replacing them with a sole reference to the newly created ns.yaml for the namespace definition. This effectively transforms the kustomization to manage only the namespace, as intended by the commit message.

No specific line changes are suggested as the current implementation correctly reflects the described intent.

Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Aug 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hugares, sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1b19696 into redhat-appstudio:main Aug 25, 2025
6 checks passed
@sadlerap sadlerap deleted the KFLUXINFRA-2111-rh02-remove-member-resources branch August 25, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants