add custom-console-url-namespace in prod #7632
Merged
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'Namespace' link in PRs check's Details is broken. This change will fix it. Example PR: https://github.com/konflux-ci/namespace-lister/pull/154/checks?check_run_id=47756929239 * Actual value in Namespace Field: https://detailurl.setting.custom-console-url-namespace.is.not.configured/ * Desired value: https://konflux-ui.apps.stone-prd-rh01.pg1f.p1.openshiftapps.com/ns/konflux-tenant-ops-tenant Signed-off-by: Francesco Ilario <[email protected]>
Code Review by GeminiThe changes introduce the Overall, the changes are consistent and correctly formatted. Review Summary:
Suggested Improvements:While the current changes are correct and functional, the repetition of adding the same pattern across multiple environment-specific files could be a point for future consideration in terms of configuration management. However, for this specific change, the approach is valid. No specific line changes are suggested as the added lines are correct as implemented. |
Signed-off-by: Francesco Ilario <[email protected]>
Code Review by GeminiThe changes introduce a new configuration setting Overall, the change is well-intentioned and addresses a clear problem. However, there is a formatting issue in several Issues and Improvements:1. YAML String Formatting (Bug) In several Files affected:
Exact lines to change:
--- a/components/pipeline-service/production/kflux-ocp-p01/deploy.yaml
+++ b/components/pipeline-service/production/kflux-ocp-p01/deploy.yaml
@@ -2448,20 +2448,22 @@ spec:
pipelines-as-code-watcher:
spec:
replicas: 2
pipelines-as-code-webhook:
spec:
replicas: 2
settings:
application-name: Konflux OCP
custom-console-name: Konflux OCP
custom-console-url: https://konflux-ui.apps.kflux-ocp-p01.7ayg.p1.openshiftapps.com
- custom-console-url-namespace: https://konflux-ui.apps.kflux-ocp-p01.7ayg.p1.openshiftapps.com/ns/{{
- namespace }}
+ custom-console-url-namespace: https://konflux-ui.apps.kflux-ocp-p01.7ayg.p1.openshiftapps.com/ns/{{ namespace }}
custom-console-url-pr-details: https://konflux-ui.apps.kflux-ocp-p01.7ayg.p1.openshiftapps.com/ns/{{
namespace }}/pipelinerun/{{ pr }}
custom-console-url-pr-tasklog: https://konflux-ui.apps.kflux-ocp-p01.7ayg.p1.openshiftapps.com/ns/{{
namespace }}/pipelinerun/{{ pr }}/logs/{{ task }}
secret-github-app-token-scoped: "false"
profile: all
pruner:
disabled: false
keep-since: 240
resources:
--- a/components/pipeline-service/production/kflux-osp-p01/deploy.yaml
+++ b/components/pipeline-service/production/kflux-osp-p01/deploy.yaml
@@ -2479,20 +2479,22 @@ spec:
pipelines-as-code-watcher:
spec:
replicas: 2
pipelines-as-code-webhook:
spec:
replicas: 2
settings:
application-name: Konflux kflux-osp-p01
custom-console-name: Konflux kflux-osp-p01
custom-console-url: https://konflux-ui.apps.kflux-osp-p01.yt45.p1.openshiftapps.com
- custom-console-url-namespace: https://konflux-ui.apps.kflux-osp-p01.yt45.p1.openshiftapps.com/ns/{{
- namespace }}
+ custom-console-url-namespace: https://konflux-ui.apps.kflux-osp-p01.yt45.p1.openshiftapps.com/ns/{{ namespace }}
custom-console-url-pr-details: https://konflux-ui.apps.kflux-osp-p01.yt45.p1.openshiftapps.com/ns/{{
namespace }}/pipelinerun/{{ pr }}
custom-console-url-pr-tasklog: https://konflux-ui.apps.kflux-osp-p01.yt45.p1.openshiftapps.com/ns/{{
namespace }}/pipelinerun/{{ pr }}/logs/{{ task }}
remember-ok-to-test: "false"
profile: all
pruner:
disabled: false
keep-since: 240
resources:
--- a/components/pipeline-service/production/kflux-prd-rh02/deploy.yaml
+++ b/components/pipeline-service/production/kflux-prd-rh02/deploy.yaml
@@ -2479,20 +2479,22 @@ spec:
pipelines-as-code-watcher:
spec:
replicas: 2
pipelines-as-code-webhook:
spec:
replicas: 2
settings:
application-name: Konflux kflux-prd-rh02
custom-console-name: Konflux kflux-prd-rh02
custom-console-url: https://konflux-ui.apps.kflux-prd-rh02.0fk9.p1.openshiftapps.com
- custom-console-url-namespace: https://konflux-ui.apps.kflux-prd-rh02.0fk9.p1.openshiftapps.com/ns/{{
- namespace }}
+ custom-console-url-namespace: https://konflux-ui.apps.kflux-prd-rh02.0fk9.p1.openshiftapps.com/ns/{{ namespace }}
custom-console-url-pr-details: https://konflux-ui.apps.kflux-prd-rh02.0fk9.p1.openshiftapps.com/ns/{{
namespace }}/pipelinerun/{{ pr }}
custom-console-url-pr-tasklog: https://konflux-ui.apps.kflux-prd-rh02.0fk9.p1.openshiftapps.com/ns/{{
namespace }}/pipelinerun/{{ pr }}/logs/{{ task }}
secret-github-app-token-scoped: "false"
profile: all
pruner:
disabled: false
keep-since: 240
resources:
--- a/components/pipeline-service/production/kflux-prd-rh03/deploy.yaml
+++ b/components/pipeline-service/production/kflux-prd-rh03/deploy.yaml
@@ -2479,20 +2479,22 @@ spec:
pipelines-as-code-watcher:
spec:
replicas: 2
pipelines-as-code-webhook:
spec:
replicas: 2
settings:
application-name: Konflux kflux-prd-rh03
custom-console-name: Konflux kflux-prd-rh03
custom-console-url: https://konflux-ui.apps.kflux-prd-rh03.nnv1.p1.openshiftapps.com
- custom-console-url-namespace: https://konflux-ui.apps.kflux-prd-rh03.nnv1.p1.openshiftapps.com/ns/{{
- namespace }}
+ custom-console-url-namespace: https://konflux-ui.apps.kflux-prd-rh03.nnv1.p1.openshiftapps.com/ns/{{ namespace }}
custom-console-url-pr-details: https://konflux-ui.apps.kflux-prd-rh03.nnv1.p1.openshiftapps.com/ns/{{
namespace }}/pipelinerun/{{ pr }}
custom-console-url-pr-tasklog: https://konflux-ui.apps.kflux-prd-rh03.nnv1.p1.openshiftapps.com/ns/{{
namespace }}/pipelinerun/{{ pr }}/logs/{{ task }}
secret-github-app-token-scoped: "false"
profile: all
pruner:
disabled: false
keep-since: 240
resources:
--- a/components/pipeline-service/production/kflux-rhel-p01/deploy.yaml
+++ b/components/pipeline-service/production/kflux-rhel-p01/deploy.yaml
@@ -2479,20 +2479,22 @@ spec:
pipelines-as-code-watcher:
spec:
replicas: 2
pipelines-as-code-webhook:
spec:
replicas: 2
settings:
application-name: Konflux kflux-rhel-p01
custom-console-name: Konflux kflux-rhel-p01
custom-console-url: https://konflux-ui.apps.kflux-rhel-p01.fc38.p1.openshiftapps.com
- custom-console-url-namespace: https://konflux-ui.apps.kflux-rhel-p01.fc38.p1.openshiftapps.com/ns/{{
- namespace }}
+ custom-console-url-namespace: https://konflux-ui.apps.kflux-rhel-p01.fc38.p1.openshiftapps.com/ns/{{ namespace }}
custom-console-url-pr-details: https://konflux-ui.apps.kflux-rhel-p01.fc38.p1.openshiftapps.com/ns/{{
namespace }}/pipelinerun/{{ pr }}
custom-console-url-pr-tasklog: https://konflux-ui.apps.kflux-rhel-p01.fc38.p1.openshiftapps.com/ns/{{
namespace }}/pipelinerun/{{ pr }}/logs/{{ task }}
remember-ok-to-test: "false"
secret-github-app-token-scoped: "false"
profile: all
pruner:
disabled: false
keep-since: 240
--- a/components/pipeline-service/production/stone-prd-rh01/deploy.yaml
+++ b/components/pipeline-service/production/stone-prd-rh01/deploy.yaml
@@ -2448,20 +2448,22 @@ spec:
pipelines-as-code-watcher:
spec:
replicas: 2
pipelines-as-code-webhook:
spec:
replicas: 2
settings:
application-name: Red Hat Konflux
custom-console-name: Red Hat Konflux
custom-console-url: https://konflux-ui.apps.stone-prd-rh01.pg1f.p1.openshiftapps.com/
- custom-console-url-namespace: https://konflux-ui.apps.stone-prd-rh01.pg1f.p1.openshiftapps.com/ns/{{
- namespace }}
+ custom-console-url-namespace: https://konflux-ui.apps.stone-prd-rh01.pg1f.p1.openshiftapps.com/ns/{{ namespace }}
custom-console-url-pr-details: https://konflux-ui.apps.stone-prd-rh01.pg1f.p1.openshiftapps.com/ns/{{
namespace }}/pipelinerun/{{ pr }}
custom-console-url-pr-tasklog: https://konflux-ui.apps.stone-prd-rh01.pg1f.p1.openshiftapps.com/ns/{{
namespace }}/pipelinerun/{{ pr }}/logs/{{ task }}
remember-ok-to-test: "false"
secret-github-app-token-scoped: "false"
profile: all
pruner:
disabled: false
keep-since: 240
--- a/components/pipeline-service/production/stone-prod-p01/deploy.yaml
+++ b/components/pipeline-service/production/stone-prod-p01/deploy.yaml
@@ -2448,20 +2448,22 @@ spec:
pipelines-as-code-watcher:
spec:
replicas: 2
pipelines-as-code-webhook:
spec:
replicas: 2
settings:
application-name: Konflux Production Internal
custom-console-name: Konflux Production Internal
custom-console-url: https://konflux-ui.apps.stone-prod-p01.wcfb.p1.openshiftapps.com
- custom-console-url-namespace: https://konflux-ui.apps.stone-prod-p01.wcfb.p1.openshiftapps.com/ns/{{
- namespace }}
+ custom-console-url-namespace: https://konflux-ui.apps.stone-prod-p01.wcfb.p1.openshiftapps.com/ns/{{ namespace }}
custom-console-url-pr-details: https://konflux-ui.apps.stone-prod-p01.wcfb.p1.openshiftapps.com/ns/{{
namespace }}/pipelinerun/{{ pr }}
custom-console-url-pr-tasklog: https://konflux-ui.apps.stone-prod-p01.wcfb.p1.openshiftapps.com/ns/{{
namespace }}/pipelinerun/{{ pr }}/logs/{{ task }}
remember-ok-to-test: "false"
secret-github-app-token-scoped: "false"
profile: all
pruner:
disabled: false
keep-since: 240
--- a/components/pipeline-service/production/stone-prod-p02/deploy.yaml
+++ b/components/pipeline-service/production/stone-prod-p02/deploy.yaml
@@ -2448,20 +2448,22 @@ spec:
pipelines-as-code-watcher:
spec:
replicas: 2
pipelines-as-code-webhook:
spec:
replicas: 2
settings:
application-name: Konflux Production Internal
custom-console-name: Konflux Production Internal
custom-console-url: https://konflux-ui.apps.stone-prod-p02.hjvn.p1.openshiftapps.com
- custom-console-url-namespace: https://konflux-ui.apps.stone-prod-p02.hjvn.p1.openshiftapps.com/ns/{{
- namespace }}
+ custom-console-url-namespace: https://konflux-ui.apps.stone-prod-p02.hjvn.p1.openshiftapps.com/ns/{{ namespace }}
custom-console-url-pr-details: https://konflux-ui.apps.stone-prod-p02.hjvn.p1.openshiftapps.com/ns/{{
namespace }}/pipelinerun/{{ pr }}
custom-console-url-pr-tasklog: https://konflux-ui.apps.stone-prod-p02.hjvn.p1.openshiftapps.com/ns/{{
namespace }}/pipelinerun/{{ pr }}/logs/{{ task }}
remember-ok-to-test: "false"
secret-github-app-token-scoped: "false"
profile: all
pruner:
disabled: false
keep-since: 240 |
mshaposhnik
approved these changes
Aug 26, 2025
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aThorp96, filariow, manish-jangra, mshaposhnik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit cdf6eff
into
redhat-appstudio:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Namespace' link in PRs check's Details is broken. This change will fix it.
Example PR: https://github.com/konflux-ci/namespace-lister/pull/154/checks?check_run_id=47756929239
Signed-off-by: Francesco Ilario [email protected]