Fix namespace-lister NetworkPolicy ingress rule #7039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm pretty sure this is a typo. If two entries appear in a list like this, they are "OR"'d together, like "any pod matching the namespace selectors" or "any pods matching the podselector [in this namespace]", which is not what we want. Things are currently working, because the namespaceselector permits *any* pod in the matched namespaces, which includes the single target pod we wanted to permit. By making this into a list of one rule, we'll permit only the matched pod in only the matched namespace to speak to this target pod.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filariow, ralphbean, sadlerap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
filariow
added a commit
to filariow/infra-deployments
that referenced
this pull request
Jul 22, 2025
promoting redhat-appstudio#7039 to production Signed-off-by: Francesco Ilario <[email protected]>
1 task
rhtap-qe-bots
pushed a commit
to redhat-appstudio-qe/infra-deployments
that referenced
this pull request
Jul 22, 2025
promoting redhat-appstudio#7039 to production Signed-off-by: Francesco Ilario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure this is a typo.
If two entries appear in a list like this, they are "OR"'d together, like "any pod matching the namespace selectors" or "any pods matching the podselector [in this namespace]", which is not what we want.
Things are currently working, because the namespaceselector permits any pod in the matched namespaces, which includes the single target pod we wanted to permit.
By making this into a list of one rule, we'll permit only the matched pod in only the matched namespace to speak to this target pod.