Syncing latest changes from upstream devel for ceph-csi - #858
Merged
Merged
Conversation
When a maintainer posts a /queue comment on a PR, immediately react to that comment with a +1 emoji to acknowledge the workflow was triggered. Assisted-by: AskBob <askbob@ibm.com> Signed-off-by: Niels de Vos <ndevos@ibm.com>
setAllMetadata called rbdImage.SetMetadata once per key, and each call opened and closed the RBD image on its own. On the CreateVolume path this meant the image was opened at least three times (the parameters map plus the clusterName and mounter keys), which is wasteful. Open the image once at the start of setAllMetadata and issue all SetMetadata calls against that single handle, closing it via defer. Apply the same change to the symmetric unsetAllMetadata, which had the identical open-per-key pattern. Behaviour is unchanged: the same keys are set/unset, the same error messages are returned, and unsetAllMetadata still tolerates ErrNotExist. Signed-off-by: Yite Gu <guyite@bytedance.com>
df-build-team
force-pushed
the
sync_us--devel
branch
2 times, most recently
from
August 30, 2026 08:06
17d8a2f to
551d6b9
Compare
…-devel Signed-off-by: DF Build Team <df-build-team@redhat.com>
df-build-team
force-pushed
the
sync_us--devel
branch
from
August 31, 2026 08:04
551d6b9 to
ac2434b
Compare
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, nixpanic The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream devel branch