Skip to content

Conversation

@jesuino
Copy link

@jesuino jesuino commented Jun 17, 2025

Updating Images size which were increased after adding dependencies for Jupyter Lab PDF export

@openshift-ci openshift-ci bot requested review from caponetto and dibryant June 17, 2025 19:56
@openshift-ci
Copy link

openshift-ci bot commented Jun 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andyatmiami for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jun 17, 2025

Hi @jesuino. Thanks for your PR.

I'm waiting for a red-hat-data-services member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member

@jstourac believes the PR should go to main branch; it would mean that gha that shows under the PR will not run against the correct images, but it does mean that the change will then be propagated to rhoai-2.22 as well as rhoai-2.23 branches as we want.

So, I'm going to access https://github.com/red-hat-data-services/notebooks/pull/899.patch (the PR url with .patch added) and i will apply patch against main and push the thing.

@jiridanek
Copy link
Member

@jiridanek jiridanek closed this Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants