Not-for-merging, info only: [sync] odh/main to rhds/main #536
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hmm, yeah. I think I know what to do next. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This does not show any conflicts when I do the merge locally. Weird. |
This updates our manifests to get rid of the following kustomize 5 warnings: ``` Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically. Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically ``` The first warning is printed by kustomize 5.0.3. The second warning by kustomize 5.6.0. The resulting manifests are still valid to be used with the kustomize 5.0.3 version and the results match what was the generated output before this change. Following commands were used to ease the manual work: ``` kustomize edit fix kustomize edit fix --vars ``` With this update we don't need the commit.yaml and params.yaml files anymore as all is now defined in the kustomization.yaml directly. Also, I kept the original variable values with the additional `_PLACEHOLDER` suffix - reason for keeping the original value is to keep them easily searchable by grep, but truth is that the value doesn't really matter after this change. https://issues.redhat.com/browse/RHOAIENG-11679
…mmits With New SHAs (#1022) * Update image related sha digests via notebooks-digest-updater GitHub action * Fix Jupyter DataScience SHA --------- Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel Lutz <[email protected]>
|
Shall we close this in favor of : #556? |
jiridanek
changed the title
RHOAIENG-11679: kustomize 5 warnings removal
Let's run on the currently used kustomize version by the operator but also with the decently new kustomize version so we are sure we are compatible with the upcoming features. This adds also STDERR output check and compares the output between these two kustomize version. Currently we have set kustomize 5.0.3 and 5.6.0. Also this adds support for the execution on non-linux/non-amd64 archs.
[GHA] Enhance the checks for the kustomization.yaml files
…for Docker image tag (#1027)
|
@jiridanek: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
having such pr open is convenient to monitor what has changed in odh
Warning
Do not click the Update branch button.