-
Notifications
You must be signed in to change notification settings - Fork 25
RHAIENG-2365, RHAIENG-2366, RHAIENG-2367: chore(build-args): update BASE_IMAGE references to use 3.2 AIPCC base images and add script for alignment automation
#1821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
This comment was marked as outdated.
This comment was marked as outdated.
0e94113 to
c481865
Compare
This comment was marked as outdated.
This comment was marked as outdated.
c481865 to
312c102
Compare
This comment was marked as outdated.
This comment was marked as outdated.
2 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
|
/build-konflux |
…BASE_IMAGE` references to use RHEL 9-based registry images and add script for alignment automation
1763f5c to
d03af8c
Compare
BASE_IMAGE references to use RHEL 9-based registry images and add script for alignment automationBASE_IMAGE references to use RHEL 9-based registry images and add script for alignment automation
BASE_IMAGE references to use RHEL 9-based registry images and add script for alignment automationBASE_IMAGE references to use 3.2 AIPCC base images and add script for alignment automation
|
/build-konflux |
|
@jiridanek: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ysok The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
atheo89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
For a future enhancement, it would be great to refactor scripts/update_konflux_args.py so the image tags aren't hardcoded inside the match/case block. If we pass them as arguments (e.g., using argparse), we can update the config files via CI/CD without modifying the Python script itself every time
https://issues.redhat.com/browse/RHAIENG-2365
https://issues.redhat.com/browse/RHAIENG-2366
https://issues.redhat.com/browse/RHAIENG-2367
Description
Build failures analysis
Codeserver builds are still flaky as usual
that is random network error
another random network error in different build
seen in https://konflux-ui.apps.stone-prod-p02.hjvn.p1.openshiftapps.com/ns/rhoai-tenant/applications/automation/pipelineruns/odh-workbench-jupyter-tensorflow-cuda-py312-on-pull-requesv9hmb/logs?task=build-images
caused by missing ppc64le eus codeready repo, https://access.redhat.com/solutions/6977790 and https://redhat-internal.slack.com/archives/C01B8PCHP1V/p1765821273030669
this will be sorted out when our devops put their subscriptions in order in konflux
How Has This Been Tested?
loads
rocm with pytorch works
cuda with tensorflow works
Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria: